Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for ProgrammaticSaveAs.md #3777

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Master-Ukulele
Copy link

This is a review for the new Programmatic Save As API

@Master-Ukulele Master-Ukulele added the API Proposal Review WebView2 API Proposal for review. label Sep 12, 2023
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
Eain Chen added 4 commits September 19, 2023 09:47
Add explanations, examples.
Add property 'Cancel', 'SuppressDefaultDialog'
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
specs/ProgrammaticSaveAs.md Outdated Show resolved Hide resolved
Eain Chen added 2 commits November 27, 2023 16:16
- More accurate the description for different Kind, including top-level document, subresources, wiki link.
- Rewrite the sample code. The methods of add event handler were removed. In new sample code, one method will both register handler and call save as.
- Add comment to address get_ContentMimeType can help the Kind selection.
- Add comment to address the CoreWebView2SaveAsUIResults will help end developer know the error if API call failed.
@Master-Ukulele Master-Ukulele added the review completed WebView2 API Proposal that's been reviewed and now needs final update and push label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review. review completed WebView2 API Proposal that's been reviewed and now needs final update and push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants