Reimagination of the web install explainer #871
+34
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes focus on store use case, broadens the importance of the feature
diekus
added
the
Web Install API
amandabaker
reviewed
Sep 19, 2024
|
|
||
| ## Goals | ||
|
|
||
| * **Enable installation of web apps (cross-origin).** | ||
| * Allow a ***vetted* installation origin** to know if the web app is installed (see *[`install_sources`](#install-sources-manifest-field) new manifest field*). | ||
|
|
There was a problem hiding this comment.
This section no longer displays with bullet points. I assume that's unintentional?
There was a problem hiding this comment.
@amandabaker not sure what you mean? I see bullet points here in the goals?
There was a problem hiding this comment.
They show as deleted for me. I wonder if it's due to the extra whitespace above?
WebInstall/explainer_cross_domain.md
Outdated
| @@ -101,10 +121,10 @@ The `navigator.install` call can receive an object with a set of parameters that | |||
| To install a same domain web site/app, the process is as follows: | |||
| 1. Origin site that triggers the installation must have installation permissions as it tries to install a cross-origin app. | |||
| 2. target site/app must comply with *[installability criteria](#installability-criteria), if any*. | |||
There was a problem hiding this comment.
Is this still true for same domain?
There was a problem hiding this comment.
Nvm, this is for the cross domain explainer. Can you update the text above to:
"To install a cross domain web site/app, the process is as follows:"
Co-authored-by: Amanda Baker <[email protected]>
Co-authored-by: Amanda Baker <[email protected]>
Co-authored-by: Amanda Baker <[email protected]>
Co-authored-by: Amanda Baker <[email protected]>
…m/diekus/MSEdgeExplainers into luigonza-install-explainer-update
amandabaker
approved these changes
Sep 19, 2024
ngaitonde
requested review from
ngaitonde
and removed request for
ngaitonde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_sourcesmanifest field, as per TAG concerns of "centralising"