Add IndexedDB getAllEntries() explainer #868
Open
+197
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```js | ||
| dictionary IDBGetAllEntriesOptions { | ||
| any query = null; // A key or an `IDBKeyRange` identifying the records to retrieve. | ||
| [EnforceRange] unsigned long count; |
There was a problem hiding this comment.
Would it be helpful to add a short inline comment // number of records to retrieve.
There was a problem hiding this comment.
Good idea. Done!
rahulsingh-msft
approved these changes
Sep 19, 2024
mwjacksonmsft
approved these changes
Sep 19, 2024
sunggook
reviewed
Sep 20, 2024
|
|
||
| [Exposed=(Window,Worker)] | ||
| partial interface IDBObjectStore { | ||
| // After the `getAllEntries()` request completes, the `IDBRequest::result` property |
There was a problem hiding this comment.
We might have to define Exceptions; maybe say it is a same with GetAll, GetAllKeys or any new exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the explainer for the IndexedDB getAllEntries() operation, which is proposed by the following W3C IndexedDB issue:
w3c/IndexedDB#206