-
Notifications
You must be signed in to change notification settings - Fork 95
Update TTL for ACR auth token #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems like the ACR auth token for service principals has a TTL of 75 minutes, not 3 hours like it said in the documentation. This change updates the documentation to be accurate.
@lindhe : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 6d728d6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Again, I want to emphasise: do not blindly merge this! I hope this is correct, but I do not know and need your help verifying it. |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
@rayoef Could you review this proposed update to your article and enter |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Thank you for your contribution to our documentation! I've confirmed with engineering that the time to live hasn't changed, so we won't be uptaking your edit. #please-close |
@lindhe The TTL for ACR access token is 1 hour. But we add a -15 min offset to token issue time to avoid clock skew between different machines. The |
Thank you for checking that! Then I must have misunderstood. Do you have any idea as to why I'm getting the timestamps shown in my example? Clearly they have 75 minutes TTL, but perhaps they are not ACR auth tokens? Are they considered something else, like "access tokens" or "refresh tokens"? 🤔 |
@lindhe You should be using access token (1hour TTL) not refresh token (3hours TTL). See my comment above why you observe 75 mins TTL. |
Ah, so they are different! That's great. I was unable to find any documentation regarding access tokens TTL, which was why I got hung up on this issue, thinking that the current documentation was incorrect. I'm guessing the TTL of access tokens is not documented anywhere, except in this thread? At least I'm unable to find it when searching around, but Azure docs is big so maybe I've missed it. I would probably have expected to find it either under "Repository-scoped access token" in this table or somewhere in the article about that topic. |
It seems like the ACR token for service principals has a TTL of 75 minutes, not 3 hours like it said in the documentation. This change updates the documentation to be accurate.
I'm using External Secrets to populate an
imagePullSecret
in Kubernetes with a token using theACRAccessToken
generator, using credentials for a Service Principal. I have configured theACRAccessToken
generator to refresh every 3 hours since that's the TTL that it said in the docs for "ACR authentication token" for a Service Principal:azure-management-docs/articles/container-registry/container-registry-authentication.md
Line 119 in 83727a4
Yet, I'm finding that the tokens I get only have a TTL of 75 minutes:
So now I'm trying to understand if the documentation is wrong or if I found the wrong documentation. I'm noting that you use the term "authentication token", not "access token", so perhaps I'm looking at the wrong thing. Am I?
If I'm right, I think we should merge this PR to fix the documentation. If I'm wrong, do you have any idea where I can find the documentation for the ACR Access Token? 🙏