-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TTL for ACR auth token #29
base: main
Are you sure you want to change the base?
Conversation
It seems like the ACR auth token for service principals has a TTL of 75 minutes, not 3 hours like it said in the documentation. This change updates the documentation to be accurate.
@lindhe : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 6d728d6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Again, I want to emphasise: do not blindly merge this! I hope this is correct, but I do not know and need your help verifying it. |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Ping |
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
It seems like the ACR token for service principals has a TTL of 75 minutes, not 3 hours like it said in the documentation. This change updates the documentation to be accurate.
I'm using External Secrets to populate an
imagePullSecret
in Kubernetes with a token using theACRAccessToken
generator, using credentials for a Service Principal. I have configured theACRAccessToken
generator to refresh every 3 hours since that's the TTL that it said in the docs for "ACR authentication token" for a Service Principal:azure-management-docs/articles/container-registry/container-registry-authentication.md
Line 119 in 83727a4
Yet, I'm finding that the tokens I get only have a TTL of 75 minutes:
So now I'm trying to understand if the documentation is wrong or if I found the wrong documentation. I'm noting that you use the term "authentication token", not "access token", so perhaps I'm looking at the wrong thing. Am I?
If I'm right, I think we should merge this PR to fix the documentation. If I'm wrong, do you have any idea where I can find the documentation for the ACR Access Token? 🙏