Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC document should not relate to DSC #126062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amitsara
Copy link

@amitsara amitsara commented Mar 4, 2025

It is not a good idea to relate Machine Configuration with DSC.
This is very confusing, we are linking the doc to DSC v2, that is talking about Get-DSCConfiguration and other DSC cmdlets that Machine configuration doesnt use.
It also gives me impression that if MC agent is using built-in dsc which is not true.

I think we need to change the text saying Machine Configuration uses DSC configurations (not DSC), also we should remove the links to DSC from the documentation.

Copy link
Contributor

@amitsara : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@amitsara : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 2566918:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/governance/machine-configuration/how-to/develop-custom-package/overview.md ⚠️Warning Details

articles/governance/machine-configuration/how-to/develop-custom-package/overview.md

  • Line 14, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'It is not a good idea to relate Machine Configuration with DSC.') are not allowed. You can only have one top-level heading.
  • Line 15, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'This is very confusing, we are linking the doc to DSC v2, that is talking about Get-DSCConfiguration and other DSC cmdlets that Machine configuration doesnt use.') are not allowed. You can only have one top-level heading.
  • Line 16, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'It also gives me impression that if MC agent is using built-in dsc which is not true.') are not allowed. You can only have one top-level heading.
  • Line 17, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'I think we need to change the text saying Machine Configuration uses DSC configurations (not DSC), also we should remove the links to DSC from the documentation.') are not allowed. You can only have one top-level heading.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@amitsara
Copy link
Author

amitsara commented Mar 4, 2025

@MutemwaRMasheke please review and provide your suggestions. Thanks

@v-dirichards
Copy link
Contributor

@michaeltlombardi The intent of the change in this PR seems to be not to fix the content but to raise an issue. You might want to close this PR and address the issue in a new PR in the private repo.

@v-dirichards v-dirichards added the aq-pr-triaged tracking label for the PR review team label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants