Add support for Win32 (serial tool only) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliott-bfs
commented
Jun 9, 2025
elliott-bfs
commented
- Added support for Win32 build in CMake build configuration.
- Added CMake flags for optionally compiling tools
- Implemented Win32 serial mac
- Added serial_mac_win.c - Added CMake options for enabling tools - Added preprocessor flags for tools - Replace stpcpy with C-standard sprintf - Added platform-independent endian.h
crypto-lars
reviewed
Jun 17, 2025
| option(WITH_TOOL_NETWORK "Build with Network tools" ON) | ||
| option(WITH_TOOL_SERIAL "Build with Serial tools" ON) | ||
|
|
||
| if (WITH_TOOL_I2C) |
There was a problem hiding this comment.
Maybe we could be more specific with the tool types in case later there are other SPI/I2C/Network tools. I would suggest to name them e.g. LINUX_SPI_SUBSYSTEM, LINUX_I2C_SUBSYSTEM, LINUX_NETWORK.
|
I have pushed some commits that I had lying around so there is a small merge conflict now that needs resolving. FYI there is also pymdfu https://github.com/microchip-pic-avr-tools/pymdfu that can do the Windows serial port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.