-
Notifications
You must be signed in to change notification settings - Fork 22
Reflect API changes in cache layer #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…are during update progress in provider
o good, I try to test it, while @MichalKrasowski review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 😃👍
@jontofront Have you had any chance to test it? I've tested in on a whole hotel automation production environment and it works like a charm. |
Yes I test it works great thanks. But I am using another Fork becouse there are sensors of battery ant Humidy. If you will have time maybe you can imoplement properly in this branch? |
I think I'll have some time to spare next week. Let me know where should I submit the PR. |
@jontofront where should I submit the PR? You mentioned some other fork before. |
@mtanasiewicz you can implement it there, I think we must have one stable repo there. I cloned this code from there https://github.com/AkiraJager/tech-controllers, because I needed |
Guys, I propose to move other changes to separate PRs, instead of running this one indefinitely. What do you say, @jontofront , @mtanasiewicz ? |
If you mean to another branch I think yes you can do it. |
@mtanasiewicz @jontofront @MichalKrasowski I dont know what is current status of this fork, but some of issues were addressed under upstream repo https://github.com/mariusz-ostoja-swierczynski/tech-controllers which is now quite activly developed and also addresses some issues mentioned here. Maybe you will be interested about it and add some contribution there. |
The goal of this PR is to fix existing bugs in the cache layer:
This is the first code written by me in the homeassistant ecosystem, as well as the first code written by me in Python. So please be understanding :)