Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cropped region and respect component sizing (if it's not fullscreen) #65

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix the cropped region and respect component sizing (if it's not fullscreen) #65

wants to merge 11 commits into from

Commits on Jul 14, 2022

  1. fix cropped region on ios

    @cdcharlebois
    cdcharlebois committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a1fd1b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. fixed crop region on android 

    Thanks to: https://github.com/rosentoshev/react-native-perspective-image-cropper/tree/master/android/src/main/java/fr/michaelvilleneuve/customcrop
    @cdcharlebois
    cdcharlebois committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    88caa60 View commit details
    Browse the repository at this point in the history

  2. Revert "fixed crop region on android" 

    This reverts commit 88caa60.
    @cdcharlebois
    cdcharlebois committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    6873798 View commit details
    Browse the repository at this point in the history

  3. Fix the crop area on Android. 

    Thanks to https://github.com/rosentoshev/react-native-perspective-image-cropper
    @cdcharlebois
    cdcharlebois committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    2cc16f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. formatting

    @cdcharlebois
    cdcharlebois committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    99b1d81 View commit details
    Browse the repository at this point in the history

  2. adjust the view-to-image methods

    @cdcharlebois
    cdcharlebois committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    bfc3003 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from cdcharlebois/fix/ios-cropped-region 

    Fix native cropped area
    @cdcharlebois
    cdcharlebois authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    fbe8bf2 View commit details
    Browse the repository at this point in the history

  4. removed comment

    @cdcharlebois
    cdcharlebois committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c6d6cde View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from cdcharlebois/fix/respect-component-sizing 

    Fix/respect component sizing
    @cdcharlebois
    cdcharlebois authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    71a5478 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. only 'contain' the image when the width is smaller than the device width

    @cdcharlebois
    cdcharlebois committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    96b0112 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from cdcharlebois/fix/respect-component-sizing 

    only 'contain' the image when the width is smaller than the device width
    @cdcharlebois
    cdcharlebois authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    a1d4f8c View commit details
    Browse the repository at this point in the history