-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CodePen): Add support for height & width options #146
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 300 300
Branches 95 96 +1
=========================================
Hits 300 300
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @talohana! 👋
Thanks for taking the time to implement this feature. 👊
I would however take a look at how the Twitch
options are implemented and make them have a default value.
Exposing a defaultOptions
value to merge them with the possible given options and pass that object back into the getHTML
function is adding unnecessary imo.
I see, it does look simpler, should I make the changes in this PR or create a new one? |
@talohana You can just hard reset this branch onto |
7fd00c4
to
94e0a3e
Compare
will this pull request be merged soon? |
I can work on it later today, @MichaelDeBoey any changes required rather than resolving the conflicts? |
e90eb17
to
fbac3f9
Compare
fbac3f9
to
4d96646
Compare
What: Added option to override hardcoded CodePen dimensions, with option to merge provided options with default options
Why: In order to change hardcoded CodePen's iframe width/height
How:
Each transformer can optionally export a
const defaultOptions
.When the plugin runs it merges provided options (
services[name]
) if exist withdefaultOptions
with precedence of provided options, and passes them as a second argument to the transformer exportedgetHTML
functionChecklist: