Weaken assertion in validate #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now possible for `mark_validated_output` to be called on a struct that we already validated via `maybe_changed_after` on one of its fields, so `validate` can no longer assert that the struct is out of date.
|
Going to go ahead and merge this to unblock getting red-knot fixed on real code; review comments should probably go to the Salsa PR anyway. |
MichaReiser
pushed a commit
that referenced
this pull request
Aug 6, 2024
It's now possible for `mark_validated_output` to be called on a struct that we already validated via `maybe_changed_after` on one of its fields, so `validate` can no longer assert that the struct is out of date.
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the last fix commit from salsa-rs#550
It's now possible for
mark_validated_outputto be called on a struct that we already validated viamaybe_changed_afteron one of its fields, sovalidatecan no longer assert that the struct is out of date.This time I actually checked incremental run on tomllib locally with this change to ensure it works.