Optimize expression processing by removing Expression.Lambda() calls. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myk0la999 Can you adapt the example for var isEvenDelegate = CachedExpressionCompiler.Instance.CachedCompileLambda(isEvenExpression); |
tb4
reviewed
Nov 18, 2024
tb4
reviewed
Nov 18, 2024
tb4
reviewed
Nov 18, 2024
tb4
reviewed
Nov 18, 2024
tb4
reviewed
Nov 18, 2024
|
Looks good to me now |
myk0la999
force-pushed
the
optimize_simplify
branch
2 times, most recently
from
02379a0 to
1a30e70
Compare
tb4
reviewed
Nov 22, 2024
tb4
reviewed
Nov 22, 2024
|
Looks good to me (only two minor things left) |
…ression.Lambda() calls
myk0la999
force-pushed
the
optimize_simplify
branch
from
1a30e70 to
2a32227
Compare
myk0la999
force-pushed
the
optimize_simplify
branch
from
5efb64e to
a41abbc
Compare
myk0la999
force-pushed
the
optimize_simplify
branch
from
6dab81d to
df5e6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a problem with lock contention caused by
Expression.Lambda()calls. This MR changes API, to add ability to operate on Expression body and parameters separately for some utils to reduce number of calls toExpression.Lambda().See: https://dev.miaplaza.com/miaplaza/website/-/issues/16248 (old) and new: https://dev.miaplaza.com/miaplaza/data/-/merge_requests/174