"Fix" for dkms #18
"Fix" for dkms #18
Conversation
|
So what was the actual change required? I see you did a bunch of config changes, added "ARCH=arm" (which i'm surprised was required, other arch packages are compiled the same way, on device). Then you built it on an arm system (which I imagined was one of the ways to work that this bug would be solved fully). What are those .config changes for? PS: Can you have one commit in the future that does both? And perhaps include the package version in the name. See git history for examples. |
There was a problem hiding this comment.
I'm not really sure. Your changes here don't really do much. The big change actually required to fix the bug (well, the most straightforward option) is moving the compilation to a native-compiler, not a cross-compiler. And for that we don't really need anything but the pkrev bump.
On the other hand the compilation time will probably go up. My bar is the 5 min ish time.
I would rather find a way to generate the required plugins even with a cross compiler, so i can keep my fast builds.
| @@ -8,7 +8,7 @@ pkgbase=linux-mister | |||
| _kernelname=${pkgbase#linux} | |||
| _desc="MiSTer" | |||
| pkgver=5.15 | |||
| pkgrel=6 | |||
| pkgrel=7 | |||
| @@ -78,6 +78,7 @@ _package() { | |||
| cd "${srcdir}/${_srcname}" | |||
|
|
|||
| KARCH=arm | |||
| ARCH=arm | |||
There was a problem hiding this comment.
Are you sure this does anything? You only declared a local variable in this function, and you're not using it anywhere. None of the subprocesses (like make) can see it.
There was a problem hiding this comment.
It is not, sorry. The only change should in pkgrel.
| @@ -3719,6 +3720,8 @@ CONFIG_INIT_STACK_NONE=y | |||
| # CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL is not set | |||
| # CONFIG_INIT_ON_ALLOC_DEFAULT_ON is not set | |||
| # CONFIG_INIT_ON_FREE_DEFAULT_ON is not set | |||
| CONFIG_CC_HAS_ZERO_CALL_USED_REGS=y | |||
There was a problem hiding this comment.
I would prefer if this file didn't change. I think the oldconfig differences here might be an artifact to you changing the compiler and that's it.
There was a problem hiding this comment.
But then I cannot do unattended builds. Suggestion?
pkgrel and config changes. Disregards the ARCH thing.
Could you try to generate mister-headers inside chroot? I only have 2 cores assigned to my archlinux vm.
What would be the goal to have mister-headers with x86_64 plugins? I think any dkms compilation will happen inside chroot. |
Fixes #17.