-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#include support for .ini files. #937
base: master
Are you sure you want to change the base?
Conversation
Just my two cents:
|
Hey, thanks for the feedback.
|
Having a default ini which is distributed and a separate ini for user edits also seems like a possible solution to this issue: |
Communication of new ini features to the average user is currently left up to the community to do via the forums (sorgelig usually mentions this in a news comment when a new Main MiSTer binary is shipped), the discord server (the news posts are rss linked to a news channel there), and users just discussing it elsewhere (bluesky, X, youtube videos, etc...). If a new feature were added, they would only be visible if someone went and manually checked their MiSTerDefaults.ini in your instance after an update, or if they read the update script feedback/log carefully. I personally don't see this as being more user friendly, it's kind of a wash. I sympathize with the efforts to address this though, it's a tough cookie to solve because MiSTer not having a fancy GUI can be a challenging limitation when coming up with solutions for potential issues like this. |
I've reverted the changes to the .ini files because I think I'm overstepping my bounds there to make such a foundational change. If I can get the #include feature in, I can use it (well, am already using it) to define whichever ini hierarchy suits my needs, without affecting other users. |
Linux guys are coming. Let's make an INI hell where settings will spread through several files.. |
This change allows settings from one .ini file to be imported from another. The main motivations for this are:
I don't know of any consistent import syntax for ini files, so I chose the common C-style #include syntax. I also considered "import=MiSTerDefaults.ini" but ultimately thought it was better to have a distinct syntax from variables.