Skip to content

Commit

Permalink
Downgrade minimum PHP version to 8.1 and Symfony dependencies to 5.4
Browse files Browse the repository at this point in the history
  • Loading branch information
loicsapone committed Sep 27, 2023
1 parent fd2f075 commit aa53901
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
operating-system: ['ubuntu-latest', 'macos-latest']
php-version: ['8.2']
php-version: ['8.1', '8.2']

steps:
- name: Checkout
Expand Down
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
}
],
"require": {
"php": "^8.2",
"symfony/framework-bundle": "^6.2",
"twig/twig": "^2.7|^3.0",
"symfony/string": "^6.2",
"symfony/http-foundation": "^6.2"
"php": "^8.1",
"symfony/framework-bundle": "^5.4 || ^6.0",
"twig/twig": "^2.7 || ^3.0",
"symfony/string": "^5.4 || ^6.0",
"symfony/http-foundation": "^5.4 || ^6.0"
},
"require-dev": {
"phpunit/phpunit": "^10.1",
Expand Down
2 changes: 1 addition & 1 deletion docker/php/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#syntax=docker/dockerfile:1.4

FROM php:8.2-cli-alpine
FROM php:8.1-cli-alpine

COPY --from=mlocati/php-extension-installer --link /usr/bin/install-php-extensions /usr/local/bin/
COPY --from=composer/composer:2-bin --link /composer /usr/bin/composer
Expand Down
12 changes: 6 additions & 6 deletions src/Resolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
use Mezcalito\ImgproxyBundle\Url\Signer;
use Symfony\Component\HttpFoundation\RequestStack;

readonly class Resolver
class Resolver
{
public function __construct(
private string $host,
private ?string $mediaUrl,
private array $presets,
private Signer $signer,
private RequestStack $requestStack,
private readonly string $host,
private readonly ?string $mediaUrl,
private readonly array $presets,
private readonly Signer $signer,
private readonly RequestStack $requestStack,
) {
}

Expand Down
6 changes: 3 additions & 3 deletions src/Url/Signer.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@

namespace Mezcalito\ImgproxyBundle\Url;

readonly class Signer
class Signer
{
private string $key;
private string $salt;
private readonly string $key;
private readonly string $salt;

public function __construct(string $key, string $salt)
{
Expand Down

0 comments on commit aa53901

Please sign in to comment.