Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Exchange Rate Provider #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonintdev
Copy link

@jonintdev jonintdev commented Oct 13, 2023

Pull Request: Create Exchange Rate Updater Project and Add Czech National Bank Connector

Overview

My main aim was to build a project that's easy to understand, use, and maintain. This led to the creation of two projects: ExchangeRateUpdater and ExchangeRateUpdater.UnitTests.

Changes Made

General

  • Updated to .NET 7.
  • Cleaned up the structure and organization of code in Program.cs.
  • Added Dependency Injection.
  • Moved data to appsettings.json and made it easier to access with a dedicated class.

Architecture

Followed the Clean Architecture approach:

  • Application: Contains the abstractions of the project.
  • Domain: Holds models, enums, and constants.
  • Infrastructure: Implements the features of the project.

Testing

Added the ExchangeRateUpdater.UnitTests project to check some logic of the application.

How to Review

  1. Clone this repository.
  2. Run the application. Go to the ExchangeRateUpdater folder: use dotnet run.
  3. Test the project. Go to the ExchangeRateUpdater folder: use dotnet test.

Development Environment

Created on a Windows 10 computer using Visual Studio 2022 Preview 17.5.0 Preview and .NET 7.

Additional Notes

I aimed to make this solution scalable with the Factory Pattern, but I also tried to keep it as simple as possible (that's why I used folders instead of separate projects, for instance).

Add new architecture and structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant