Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

114 industrial emissions data sourcing #140

Merged
merged 53 commits into from
Jan 13, 2025

Conversation

pawilfahrt
Copy link
Collaborator

@pawilfahrt pawilfahrt commented Dec 12, 2024

This PR pulls in industrial data from three principal sources: the EPA National Emissions Inventory (NEI), the EPA GHG Reporting Program (GHGRP) and an MPCA provided fuel throughput dataset. The complementarity and weaknesses of these three datasets are explored in detail in the industrial_data_source.qmd file.

The files needing the most thorough attention are:
compile_ghgrp_emissions (brings in full dataset)
compile_fuel_combustion (breaks subpart c, fuel combustion, of ghgrp into constituent fuel types)
compile_mpca_industrial_fuel_permits (brings in MPCA dataset)
model_baseline_industrial_emissions (attempts to backcast to earlier years of emissions by anchoring to the MN GHG Inventory)

NEI data should also be reviewed, but is difficult to use due to broad categorization that included powerplants and other double counted emission sources, so is currently not being reported to county_emissions.

FLIGHT data was a wrapper for GHGRP which was processed prior to finding the GHGRP core data, which provides much more flexibility and information.

Some comparisons between MPCA and EPA data were started, but need to be revisited later and can be ignored for now.

Checklist

Please complete this checklist as a courtesy to the PR reviewer.

Code and styling

  • All of the files/scripts I added are in the right place and named appropriately. See the README for details.
  • I have not used setwd()
  • I have used file.path(here::here(), "file_name")) to source any scripts or read in data
  • I have not added any large datasets, unless absolutely necessary (explain)
  • I have commented my code, particularly in hard to understand areas
  • I have added additional package dependencies as necessary with renv::install()
  • I have run styler::style_dir(".", recursive = TRUE, filetype = c("R", "qmd"))
  • Plots
    • If plotly, use source = "chunk-name" in plot_ly()
    • Use formatting with councilR::plotly_layout()?
  • Chunk formatting
    • All chunks named
    • All figure or table chunks have caption
    • out.width: "95%". If a specific height is needed, use pixels. and/or out.height: "500px"

Document editing

  • I have ensured that modified documents knit successfully from render_for_publication.R
  • I have fixed any missing citations, cross references, hyperlinks
  • I have reviewed my contributions for typos and misspellings.

GitHub and project management

  • I have identified and assigned at least one Reviewer (Liz, Sam, Laine) to this PR
  • I have assigned myself to this PR
  • I have updated the status in the GitHub Project

@pawilfahrt pawilfahrt added the industrial Industrial point source emissions label Dec 12, 2024
@pawilfahrt pawilfahrt self-assigned this Dec 12, 2024
Copy link
Collaborator

@LimerickSam LimerickSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments on specific scripts. I figured that was the best way to advance the conversation! There's only a couple of points that perhaps we should discuss, which may (or may not) yield some minor changes, upon which time I could approve.

Copy link
Collaborator

@LimerickSam LimerickSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the following issues noted to be addressed in a subsequent release/PR:

issues to work on down the road. Those being, in order of importance:

  1. Filter out remaining CMAP doublecounts
  2. Investigate city/township point sources
  3. Reconcile GWPs
  4. Potentially others

@LimerickSam LimerickSam merged commit 684cc56 into dev-2005-baseline Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
industrial Industrial point source emissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants