-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.0 refactor #56
Merged
Merged
0.6.0 refactor #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Code Format Refactor - Bumped minimum package API version to Meteor 1.3 (to support Tracker) - Changed Deps to Tracker (#49) - Only show log output in development
Replaced internal references from Dep to Tracker Changed some non-changing variables from let to const
- Added _timeSync Meteor Method for doing timesync over DDP instead of HTTP - Auto switch to DDP after initial HTTP timesync to improve subsequent round trip times - Added option TimeSync.forceDDP to always use DDP, even for first sync (which may be slow!) - Shortened resync interval from 1 minute to 30 seconds when using DDP. - Added tests for DDP and HTTP sync - Added option to set the timesync URL using `TimeSync.setSyncUrl`
Seriously we don't need that at this date.
The CI is running, but the tests are not being run. Might need to do a different approach. |
On my machine the tests are passing, will release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for v0.6 version. Right now 2 tests fail. Once fixed then this version will be released.
Contributions welcome!