Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primary and secondary colors #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aonez
Copy link

@aonez aonez commented Nov 5, 2024

Forcing .black and .white does not fit the Dark mode.

Forcing `.black` and `.white` does not fit the Dark mode.
@Metamogul
Copy link
Owner

Hey @aonez, thanks for the contribution! I've tested your addition and it seems like there's still a few elements where text colors are still not compatible with dark mode. You'll find them when quickly searching through the project for Color. Specifically two occurrences of Color.black make that text really hard to read in dark mode. Would you mind changing these too so I can happily merge your MR?

@aonez
Copy link
Author

aonez commented Nov 5, 2024

@Metamogul I did a search for Color before the PR and did not found more places other that here:

.foregroundColor(configuration.isPressed ? Color.white : Color.pink)
.background(configuration.isPressed ? Color.pink : Color.pink.opacity(0.2))

But since it is for a custom button with pink I did not changed that, it looks ok (pink is questionable for standard colors). Can you point me where should be those other occurences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants