[v16] bump ethereum-related dependencies #477

legobeat · 2024-04-18T04:20:48Z

Description

Targeting v16.x.

Bump ethereumjs and metamask library packages to latest preserving compatibility with Nodejs v12.

Update eth-rpc-errors from ^3.0.0 to ^4.0.3
Update from eth-sig-util@^1.4.2 to @metamask/eth-sig-util@^4.0.1
- The remaining usage of eth-sig-util@1 still present in lockfile comes from ganache-core, which is a devDependency only used for tests.
Update ethereumjs- packages
Update eth-json-rpc-filters from ^4.2.1 to ~5.0.0
- 5.1.0 breaks node v12
Update from eth-json-rpc-infura@^5.1.0 to @metamask/eth-json-rpc-infura@^6.0.0
Fix resolution of ethereumjs-abi to fetch from package registry instead of github.com via git+http.
devDeps: Update from ganache-core to ganache-cli

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/[email protected]	Transitive: environment, eval, filesystem, network, shell	`+18`	1.52 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`+4`	114 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	65.2 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem, unsafe	`+14`	2.77 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+2`	606 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+3`	94.2 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+7`	555 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	63.8 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	11.7 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	1.88 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem Transitive: unsafe	`+99`	4.12 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	68.9 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`+3`	2.5 MB	nicolo-ribaudo
npm/@cypress/[email protected]	environment, filesystem, network	`+33`	2.2 MB	cypress-npm-publisher
npm/@jridgewell/[email protected]	None	`0`	17.9 kB	jridgewell
npm/@jridgewell/[email protected]	None	`+1`	224 kB	jridgewell
npm/@ljharb/[email protected]	None	`0`	31.7 kB	ljharb
npm/@metamask/[email protected]	None	`+2`	97.6 kB	gudahtt
npm/@metamask/[email protected]	Transitive: environment, filesystem	`+19`	8.76 MB	gudahtt
npm/[email protected]	environment, filesystem Transitive: shell	`+3`	93.7 kB	ai
npm/[email protected]	None	`+3`	56.4 kB	ljharb
npm/[email protected]	None	`0`	7.45 kB	sindresorhus
npm/[email protected]	None	`+2`	60.7 kB	bcoe
npm/[email protected]	None	`0`	2.94 kB	sindresorhus
npm/[email protected]	None	`+2`	50.4 kB	ljharb
npm/[email protected]	None	`+1`	39.4 kB	ljharb
npm/[email protected]	None	`+40`	3.22 MB	ljharb
npm/[email protected]	None	`0`	12.3 kB	ljharb
npm/[email protected]	Transitive: environment, filesystem	`+29`	8.89 MB	gudahtt
npm/[email protected]	network Transitive: environment, filesystem	`+21`	8.76 MB	gudahtt
npm/[email protected]	None	`0`	52.2 kB	rekmarks
npm/[email protected]	environment, shell Transitive: filesystem	`+6`	49 kB	sindresorhus
npm/[email protected]	None	`0`	39.7 kB	matteo.collina
npm/[email protected]	Transitive: filesystem	`+5`	28.8 kB	sindresorhus
npm/[email protected]	None	`0`	31.4 kB	ljharb
npm/[email protected]	environment, filesystem, shell, unsafe	`0`	22.7 MB	truffle-cicd
npm/[email protected]	None	`0`	4.72 kB	stefanpenner
npm/[email protected]	eval	`0`	41.6 kB	ljharb
npm/[email protected]	None	`+1`	22.7 kB	ljharb
npm/[email protected]	None	`0`	12 kB	ljharb
npm/[email protected]	None	`0`	17.6 kB	ljharb
npm/[email protected]	None	`0`	3.02 kB	tarruda
npm/[email protected]	None	`0`	8.77 kB	ljharb
npm/[email protected]	None	`0`	2.38 kB	sindresorhus
npm/[email protected]	None	`0`	18.7 kB	ljharb
npm/[email protected]	None	`+2`	57.7 kB	ljharb
npm/[email protected]	None	`0`	19.4 kB	ljharb
npm/[email protected]	None	`0`	6.37 kB	sindresorhus
npm/[email protected]	None	`+1`	11.3 kB	samverschueren
npm/[email protected]	None	`+1`	13.3 kB	sindresorhus
npm/[email protected]	None	`0`	54.5 kB	ljharb
npm/[email protected]	network	`+3`	493 kB	node-fetch-bot
npm/[email protected]	None	`0`	34 kB	chicoxyzzy
npm/[email protected]	environment	`0`	6.18 kB	sindresorhus
npm/[email protected]	Transitive: unsafe	`+2`	77.4 kB	ljharb
npm/[email protected]	environment	`+5`	147 kB	matteo.collina
npm/[email protected]	None	`+2`	73.8 kB	ljharb
npm/[email protected]	filesystem	`0`	12.1 kB	troygoode
npm/[email protected]	None	`0`	3.93 kB	bcoe
npm/[email protected]	None	`0`	4.22 kB	bcoe
npm/[email protected]	None	`+1`	120 kB	ljharb
npm/[email protected]	None	`0`	9.96 kB	isaacs
npm/[email protected]	None	`+1`	42.7 kB	ljharb
npm/[email protected]	environment, filesystem	`+12`	670 kB	ljharb
npm/[email protected]	None	`0`	4.04 kB	nexdrew
npm/[email protected]	None	`+3`	79.7 kB	ljharb
npm/[email protected]	filesystem	`0`	11 kB	oss-bot
npm/[email protected]	environment	`0`	57.1 kB	oss-bot
npm/[email protected]	environment, filesystem	`0`	228 kB	bcoe

View full report↗︎

socket-security · 2024-04-18T04:21:15Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

legobeat · 2024-04-18T04:31:36Z

@SocketSecurity ignore npm/[email protected]

network access ok

legobeat · 2024-04-18T05:05:54Z

@SocketSecurity ignore npm/@ethersproject/[email protected]
@SocketSecurity ignore npm/[email protected]

network access ok

the github.com version comes from devDependency ganache-core - resolution only relevant for build/dev

legobeat · 2024-04-18T06:05:42Z

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

new author ok

legobeat · 2024-04-18T06:06:08Z

@SocketSecurity ignore npm/[email protected]

new author ok

legobeat · 2024-04-18T06:06:32Z

@SocketSecurity ignore npm/[email protected]

new author ok

legobeat · 2024-04-18T06:07:03Z

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

ganache update ok

Gudahtt

LGTM!

legobeat force-pushed the v16-deps-bumps branch from 673362a to 2423ad7 Compare April 18, 2024 04:30

legobeat force-pushed the v16-deps-bumps branch from 2423ad7 to b3f1389 Compare April 18, 2024 05:04

legobeat added 4 commits April 18, 2024 05:29

deps: eth-json-rpc-middleware@^6.0.0->^8.1.0

55c3767

deps: eth-rpc-errors@^3.0.0->^4.0.3

0ab1e92

deps: update ethereumjs packages

af1b13f

deps: eth-json-rpc-filters@^4.2.1->~5.0.0

371d0b1

legobeat force-pushed the v16-deps-bumps branch from b3f1389 to a2cd96c Compare April 18, 2024 05:29

legobeat marked this pull request as ready for review April 18, 2024 05:31

legobeat requested a review from a team as a code owner April 18, 2024 05:31

legobeat requested review from kumavis, Gudahtt, mcmire and rekmarks April 18, 2024 05:32

legobeat added 3 commits April 18, 2024 05:47

deps: eth-json-rpc-infura@^5.1.0 -> @metamask/eth-json-rpc-infura@^6.0.0

92a6493

deps: eth-sig-util@^1.4.2 -> @metamask/eth-sig-util@^4.0.1

9d6b934

fix ethereumjs-abi resolution from github to registry

98b22f3

the github.com version comes from devDependency ganache-core - resolution only relevant for build/dev

legobeat force-pushed the v16-deps-bumps branch from a2cd96c to 75f7b24 Compare April 18, 2024 05:48

devDeps: ganache-core@^2.7.0->^2.13.2 -> [email protected]

9d9306b

legobeat force-pushed the v16-deps-bumps branch from 75f7b24 to 9d9306b Compare April 18, 2024 05:49

legobeat added 2 commits April 18, 2024 06:02

fix ethereumjs-abi resolution from github to registry

ae9c853

chore: securitry-related package lockbumps

c96396c

Gudahtt approved these changes Apr 19, 2024

View reviewed changes

legobeat merged commit 277e195 into MetaMask:v16.x Apr 22, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v16] bump ethereum-related dependencies #477

[v16] bump ethereum-related dependencies #477

legobeat commented Apr 18, 2024 •

edited

Loading

socket-security bot commented Apr 18, 2024 •

edited

Loading

socket-security bot commented Apr 18, 2024 •

edited

Loading

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024 •

edited

Loading

Gudahtt left a comment

[v16] bump ethereum-related dependencies #477

[v16] bump ethereum-related dependencies #477

Conversation

legobeat commented Apr 18, 2024 • edited Loading

Description

Related

socket-security bot commented Apr 18, 2024 • edited Loading

socket-security bot commented Apr 18, 2024 • edited Loading

Next steps

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024

legobeat commented Apr 18, 2024 • edited Loading

Gudahtt left a comment

Choose a reason for hiding this comment

legobeat commented Apr 18, 2024 •

edited

Loading

socket-security bot commented Apr 18, 2024 •

edited

Loading

socket-security bot commented Apr 18, 2024 •

edited

Loading

legobeat commented Apr 18, 2024 •

edited

Loading