Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some notation fixes on contributing.md #2369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Some notation fixes on contributing.md #2369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b085fcd
Update contributing.md
reziamini Apr 29, 2024
a04d389
Merge branch 'main' into patch-1
reziamini May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ To use preview builds locally, follow these steps:
GITHUB_NPM_TOKEN=<your personal access token> METAMASK_NPM_REGISTRY=https://npm.pkg.github.com yarn install
```

- It's recommended to use your machine's local keychain to store the token,
- It's recommended to use your machine's local keychain to store the token
and retrieve it from there. For example on macOS, you can use:
```bash
GITHUB_NPM_TOKEN=$(security find-generic-password -s 'GitHub NPM Token' -w) METAMASK_NPM_REGISTRY=https://npm.pkg.github.com yarn install
Expand Down Expand Up @@ -168,7 +168,7 @@ GitHub action are used to automate the release process.

2. **Update changelogs for relevant packages.**

At this point you will be on a new release branch, and a new section will
At this point, you will be on a new release branch, and a new section will
have been added to the changelog of each package you specified in the
previous step.

Expand Down Expand Up @@ -200,7 +200,7 @@ GitHub action are used to automate the release process.
"Release \<new version\>".

If changes are made to the base branch, the release branch will need to be
updated with these changes and review/QA will need to restart again. As such,
updated with these changes, and review/QA will need to restart again. As such,
it's probably best to avoid merging other PRs into the base branch while
review is underway.

Expand All @@ -224,4 +224,4 @@ GitHub action are used to automate the release process.

Once the `publish-npm` job has finished,
[check NPM](https://npms.io/search?q=scope%3Ametamask) to verify that all
relevant packages has been published.
relevant packages have been published.