Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify snaps in the registry #67

Merged
merged 10 commits into from
Sep 4, 2023
Merged

Verify snaps in the registry #67

merged 10 commits into from
Sep 4, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 31, 2023

This adds a script to verify snaps in the registry, which is called in CI.

@socket-security
Copy link

socket-security bot commented Aug 31, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @ethereumjs/[email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

package.json Outdated Show resolved Hide resolved
scripts/verify-snaps.ts Show resolved Hide resolved
@Mrtenz Mrtenz marked this pull request as ready for review August 31, 2023 12:29
@Mrtenz Mrtenz requested a review from a team as a code owner August 31, 2023 12:29
@socket-security
Copy link

socket-security bot commented Sep 4, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/utils 5.0.2 None +10 1.61 MB metamaskbot

@Mrtenz
Copy link
Member Author

Mrtenz commented Sep 4, 2023

@SocketSecurity ignore-all

These are fine.

@Mrtenz Mrtenz merged commit 54d1bbe into main Sep 4, 2023
21 checks passed
@Mrtenz Mrtenz deleted the mrtenz/verify-snaps branch September 4, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants