-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new snap metadata #49
Conversation
The added metadata will be visible to users when they're adding a new snap account. All the newly introduced fields are optional, as they might not be necessary for other types of snaps.
I've looked at this a bunch of times and I think I like it. It would be helpful to start using this. I have a feeling we will eventually decide to change this approach and do something different with a "v2" but we can cross that bridge when we get there. I'm curious to hear @FrederikBolding's thoughts as well. |
Co-authored-by: Frederik Bolding <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please hold off merging until @Mrtenz also looks at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A support URL could be useful?
Could be indeed. @AlexJupiter, WDYT? |
Keep in mind that this may be used by other things than just the accounts team work 😉 You don't have to use it necessarily |
Yes, sure, this seems like a good addition. |
The added metadata will be visible to users when they're adding a new snap account. All the newly introduced fields are optional, as they might not be necessary for other types of snaps.
Closes: MetaMask/accounts-planning/issues/21