Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(builds): CocoaPods install without Flipper #6955

Closed
wants to merge 8 commits into from
Closed

ci(builds): CocoaPods install without Flipper #6955

wants to merge 8 commits into from

Commits on Aug 2, 2023

  1. Remove trailing space

    @leotm
    leotm committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0a18925 View commit details
    Browse the repository at this point in the history

  2. Update BitRise to pod install without Flipper 

    Issue
- Fix: facebook/flipper#4278

Follow-up
- #6944

Changes
- Remove `cocoapods-install@2` configs that don't support custom flags like `NO_FLIPPER=1`
- Replace with scripts that `pod install` without Flipper

Refs
- https://github.com/facebook/react-native/releases/tag/v0.71
- https://github.com/bitrise-steplib/steps-cocoapods-install
  - Inputs command flags unsupported

Docs
- https://bitrise.io/integrations/steps/cocoapods-install
- https://devcenter.bitrise.io/en/steps-and-workflows/workflow-recipes-for-ios-apps/-ios--install-cocoapods-dependencies.html
- https://devcenter.bitrise.io/en/dependencies-and-caching/managing-dependencies-for-ios-apps/managing-dependencies-with-cocoapods.html

Improvement
- Make this one script
    @leotm
    leotm committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7534886 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Merge branch 'main' into bitrise/pod-install-no-flipper

    @leotm
    leotm authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    605d342 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into bitrise/pod-install-no-flipper

    @leotm
    leotm authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    aff025e View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Fix react-native-flipper iOS build fail 

    Exclude react-native-flipper via react-native.config.js
since  it depends on FlipperKit
    @leotm
    leotm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ff06275 View commit details
    Browse the repository at this point in the history

  2. Fix Podfile post_install indentation

    @leotm
    leotm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5dfe72a View commit details
    Browse the repository at this point in the history

  3. Remove stale Podfile flipper_post_install call 

    Since this is still calling scripts/cocoapods/flipper.rb:
Setting React-RCTAppDelegate > config.build_settings > FB_SONARKIT_ENABLED=1
Causing React/AppSetup/RCTAppSetupUtils.mm to wrongly try importing FlipperKit

Introduced in RN v0.62
- https://github.com/facebook/react-native/blob/v0.62.0/template/ios/Podfile
- #1586

We should have removed in RN v0.64
- https://github.com/facebook/react-native/blob/v0.64.0/template/ios/Podfile
- https://github.com/facebook/react-native/blob/v0.63.5/template/ios/Podfile
    @leotm
    leotm committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    530c29e View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge branch 'main' into bitrise/pod-install-no-flipper

    @leotm
    leotm authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    020f2da View commit details
    Browse the repository at this point in the history