chore: revert flipper integration #6944
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: [email protected], [email protected] |
sethkfman
added
the
needs-dev-review
|
Kudos, SonarCloud Quality Gate passed!
|
Issue - Fix: facebook/flipper#4278 Follow-up - #6944 Branch from - #6851 File changes - package.json - yarn lockfile - cocoapods lockfile
There was a problem hiding this comment.
approved as well to unblock build_ios_release v7.5.0-RC-1 ^
as follow-up "react-native-flipper": "0.163.0", (downgrade from ^0.206.0) should fix
@jpcloureiro i've restored your prev pr branch
i'll add a pr with 0.163.0 we can look at after
better solution: excluding Flipper in CI for faster stable builds (introduced in 0.71.1)
Exclude react-native-flipper when NO_FLIPPER=1 to prevent iOS build fail (f47b5b8b5d by @retyui)
in our BitRise cocoapods-install@2 steps
- build_ios_release
- ios_e2e_test
- build_ios_qa
i'll add a pr with this improvement too after
then we can likely bump back to ^0.206.0+
Issue - Fix: facebook/flipper#4278 Follow-up - #6944 Changes - Remove `cocoapods-install@2` configs that don't support custom flags like `NO_FLIPPER=1` - Replace with scripts that `pod install` without Flipper Refs - https://github.com/facebook/react-native/releases/tag/v0.71 - https://github.com/bitrise-steplib/steps-cocoapods-install - Inputs command flags unsupported Docs - https://bitrise.io/integrations/steps/cocoapods-install - https://devcenter.bitrise.io/en/steps-and-workflows/workflow-recipes-for-ios-apps/-ios--install-cocoapods-dependencies.html - https://devcenter.bitrise.io/en/dependencies-and-caching/managing-dependencies-for-ios-apps/managing-dependencies-with-cocoapods.html Improvement - Make this one script
sethkfman
added
needs-qa
chrisleewilcox
added
QA in Progress
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)Description
Reverted Flipper Integration PR to unblock iOS build error.
See successful build
Screenshots/Recordings
NA