tmp: investigate notification e2e smoke issue

[Prithpal-Sooriya]

Description

This is not to be merged.

Investigated the issues we have with upgrading some controllers:

• @metamask/notification-services-controller
• @metamask/profile-sync-controller

Here are some breakdown notes:

e2e compilation issues
This was resolved in: MetaMask/core#4721
It seems there was an issue with compiling exported async arrow functions with hermes. This has now been resolved.

e2e failing
Now it seems that e2e tests are outright failing, which is odd. To keep scope minimal, we are only upgrading the packages in this PR.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	0	1.21 MB	metamaskbot
npm/@metamask/[email protected]	network	0	1.01 MB	metamaskbot
npm/[email protected]	None	0	29.6 kB	sindresorhus

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9e9061c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09966e05-1048-4d15-b08e-ae0f37855a42

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud