Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(1702-2): auto detect nft component #11364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

Description

This PR is part of a series that breaks down the original large PR #11127 into smaller, more manageable chunks.

The AutoDetectNFTSettings functionality is valuable beyond its original implementation. By converting it into a reusable component, we can:

  1. Improve code maintainability
  2. Reduce duplication
  3. Enhance consistency across the application and ease of use

Changes

  • Extracted AutoDetectNFTSettings logic from its original location SecuritySettings and into a separate component file
  • Included new tests
  • Updated the SecuritySettings to use the new component

Impact

This refactored component will be used in:

  • Its current original screen which is SecuritySettings
  • New screens coming from the enhanced onboarding settings #1702 that is currently under progress

Related issues

Feature: #1702

Manual testing steps

  1. On the wallet home screen, click on the NFTs tab and make sure they are there (use account with NFTs)
  2. Goto the settings page
  3. Click on Security Settings
  4. Scroll down to Toggle the "Autodetect NFTs" and toggle to off
  5. Check home screen under the NFT tab to make sure the enable Autodetect NFT banner is visible
  6. Go back and toggle it back to on
  7. Go back to the home screen wallet under NFT tabs. Make sure the banner is off

Screenshots/Recordings

Scenario 1 Scenario 2
1 2

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner September 20, 2024 23:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 20, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2681a9b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2576f542-e407-4a81-9a3a-862bbf74b917

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 89ccef2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6416b678-9d2c-43f6-90c1-3bbadaa6cacd

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aa3535a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8158c7c8-4e29-4c7b-b5bf-7fe297fb8f03

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant