Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(1702-1): auto detect tokens component #11363

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Sep 20, 2024

Description

This PR is part of a series that breaks down the original large PR #11127 into smaller, more manageable chunks.

The AutoDetectToken functionality is valuable beyond its original implementation. By converting it into a reusable component, we can:

  1. Improve code maintainability
  2. Reduce duplication
  3. Enhance consistency across the application and ease of use

Changes

  • Extracted AutoDetectToken logic from its original location into a separate component file
  • Included new tests
  • Updated the original screen to use the new component
  • Updated copy

Impact

This refactored component will be used in:

  • Its current original screen
  • New screens coming from the enhanced onboarding settings #1702 that is currently under progress

Related issues

Feature: #1702

Manual testing steps

  1. On the wallet home screen check for the text "x new tokens found in this account"
  2. Goto the settings page
  3. Click on Advanced Settings
  4. Toggle the "Auto Detect Tokens" to off
  5. Check home screen to see that "x new tokens found in this account" had disappeared
  6. Repeat steps 1-5 to make sure the toggle is working

Screenshots/Recordings

auto_detect_tokens

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Sep 20, 2024
@vinnyhoward vinnyhoward requested a review from a team as a code owner September 20, 2024 22:04
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0adb142
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac4ae001-1a34-46a1-98ec-4215ac93cfbb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward changed the title refactor(1702): auto detect tokens component refactor(1702-1): auto detect tokens component Sep 20, 2024
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c2ab689
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d6edf2d5-bdca-4e41-8d06-6513c43600c3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Sep 20, 2024

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1942e95
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65dd58da-613b-4741-8f82-e1716a0e9d73

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant