chore(js-ts): Convert app/components/Base/RangeInput.js to TypeScript #11336
+74
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
bot
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Cal-L
reviewed
Sep 24, 2024
| @@ -172,7 +229,7 @@ const RangeInput = ({ | |||
| {renderLabelComponent(rightLabelComponent)} | |||
| </View> | |||
|
|
|||
| <View style={styles.rangeInputContainer(Boolean(error))}> | |||
| <View style={[styles.rangeInputContainer, hasError ? styles.rangeInputContainerError : styles.rangeInputContainerNormal]}> | |||
There was a problem hiding this comment.
For Devin reference: This way of applying styles is fine. The other way that we can apply dynamic styles is by using the useStyles hook. You can reference TagBase.tsx as an example.
Cal-L
reviewed
Sep 24, 2024
devin-ai-integration
bot
added
the
skip-sonar-cloud
devin-ai-integration
bot
added
needs-dev-review
devin-ai-integration
bot
added
skip-sonar-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the RangeInput component from JavaScript to TypeScript. Please review the changes.
This Devin run was requested by Jeffrey.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!