-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add @MetaMask/metamask-assets
to CODEOWNERS
#11329
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: sethkfman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Would it be possible to group files under a common folder, for instance app/components/UI/assets for the UI so that you could apply the owners only to the folder? Having it applied on each individual file is going to make it had for any refactor if needed and would force to add owner line each time you add a new one.
This was something that we talked about during our initial discovery call. I think that this is where we would like to end up, but that we decided that separating by file (the changes in this PR) would be the first step along that effort. Going to tag @sethkfman and @Cal-L on this comment for visibility. Should we handle the |
@NicolasMassart Great callout. This will be the next phase of CODEOWNER implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Description
Initial pass at adding certain codepaths for assets team to codeown. Feel free to suggest additions or removals for things I don't have context about!
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-391
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist