Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add @MetaMask/metamask-assets to CODEOWNERS #11329

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 19, 2024

Description

Initial pass at adding certain codepaths for assets team to codeown. Feel free to suggest additions or removals for things I don't have context about!

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-391

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 19, 2024
@gambinish gambinish marked this pull request as ready for review September 20, 2024 17:33
@gambinish gambinish requested a review from a team as a code owner September 20, 2024 17:33
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Would it be possible to group files under a common folder, for instance app/components/UI/assets for the UI so that you could apply the owners only to the folder? Having it applied on each individual file is going to make it had for any refactor if needed and would force to add owner line each time you add a new one.

@gambinish
Copy link
Contributor Author

Suggestion: Would it be possible to group files under a common folder, for instance app/components/UI/assets for the UI so that you could apply the owners only to the folder? Having it applied on each individual file is going to make it had for any refactor if needed and would force to add owner line each time you add a new one.

This was something that we talked about during our initial discovery call. I think that this is where we would like to end up, but that we decided that separating by file (the changes in this PR) would be the first step along that effort.

Going to tag @sethkfman and @Cal-L on this comment for visibility. Should we handle the assets subdirectory here or does it make sense to save that for later?

@sethkfman
Copy link
Contributor

@NicolasMassart Great callout. This will be the next phase of CODEOWNER implementation.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Sep 27, 2024

@gambinish gambinish added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 7ac6520 Sep 27, 2024
36 checks passed
@gambinish gambinish deleted the chore/MMASSETS-391_mobile-assets-codeowners branch September 27, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants