Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove feature flag for multichain asset list #28450

Open
wants to merge 14 commits into
base: feat/mmassets-432_network-filter-extension--integration-balances
Choose a base branch
from
1 change: 1 addition & 0 deletions .storybook/test-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,7 @@ const state = {
order: 'dsc',
sortCallback: 'stringNumeric',
},
tokenNetworkFilter: {},
},
incomingTransactionsPreferences: {
[CHAIN_IDS.MAINNET]: true,
Expand Down
1 change: 1 addition & 0 deletions app/scripts/constants/sentry-state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ export const SENTRY_BACKGROUND_STATE = {
showFiatInTestnets: true,
showTestNetworks: true,
smartTransactionsOptInStatus: true,
tokenNetworkFilter: {},
showNativeTokenAsMainBalance: true,
petnamesEnabled: true,
showConfirmationAdvancedDetails: true,
Expand Down
2 changes: 0 additions & 2 deletions builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,6 @@ env:
- BARAD_DUR: ''
# Determines if feature flagged Chain permissions
- CHAIN_PERMISSIONS: ''
# Determines if Portfolio View UI should be shown
- PORTFOLIO_VIEW: ''
# Enables use of test gas fee flow to debug gas fee estimation
- TEST_GAS_FEE_FLOWS: false
# Temporary mechanism to enable security alerts API prior to release
Expand Down
10 changes: 9 additions & 1 deletion lavamoat/build-system/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,8 @@
"chokidar>normalize-path": true,
"chokidar>readdirp": true,
"del>is-glob": true,
"eslint>glob-parent": true
"eslint>glob-parent": true,
"tsx>fsevents": true
}
},
"chokidar>anymatch": {
Expand Down Expand Up @@ -8767,6 +8768,13 @@
"typescript": true
}
},
"tsx>fsevents": {
"globals": {
"console.assert": true,
"process.platform": true
},
"native": true
},
"typescript": {
"builtin": {
"buffer.Buffer": true,
Expand Down
1 change: 1 addition & 0 deletions test/e2e/default-fixture.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ function defaultFixture(inputChainId = CHAIN_IDS.LOCALHOST) {
order: 'dsc',
sortCallback: 'stringNumeric',
},
tokenNetworkFilter: {},
shouldShowAggregatedBalancePopover: true,
},
selectedAddress: '0x5cfe73b6021e818b776b421b1c4db2474086a7e1',
Expand Down
3 changes: 3 additions & 0 deletions test/e2e/fixture-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ function onboardingFixture() {
order: 'dsc',
sortCallback: 'stringNumeric',
},
tokenNetworkFilter: {},
shouldShowAggregatedBalancePopover: true,
},
useExternalServices: true,
Expand Down Expand Up @@ -126,6 +127,7 @@ function onboardingFixture() {
},
showTestNetworks: false,
smartTransactionsOptInStatus: true,
tokenNetworkFilter: {},
},
QueuedRequestController: {
queuedRequestCount: 0,
Expand Down Expand Up @@ -664,6 +666,7 @@ class FixtureBuilder {
return this.withPreferencesController({
preferences: {
smartTransactionsOptInStatus: true,
tokenNetworkFilter: {},
},
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,38 +67,38 @@
"srcNetworkAllowlist": { "0": "string", "1": "string", "2": "string" },
"destNetworkAllowlist": { "0": "string", "1": "string", "2": "string" }
},
"srcTokens": {},
"srcTopAssets": {},
"destTokens": {},
"destTopAssets": {},
"quoteRequest": {
"slippage": 0.5,
"srcTokenAddress": "0x0000000000000000000000000000000000000000"
"srcTokenAddress": "0x0000000000000000000000000000000000000000",
"slippage": 0.5
},
"quotes": {},
"quotesRefreshCount": 0,
"srcTokens": {},
"srcTopAssets": {}
"quotesRefreshCount": 0
}
},
"CronjobController": { "jobs": "object" },
"CurrencyController": {
"currentCurrency": "usd",
"currencyRates": {
"ETH": {
"conversionDate": "number",
"conversionRate": 1700,
"usdConversionRate": 1700
},
"LineaETH": {
"SepoliaETH": {
"conversionDate": "number",
"conversionRate": 1700,
"usdConversionRate": 1700
},
"SepoliaETH": {
"LineaETH": {
"conversionDate": "number",
"conversionRate": 1700,
"usdConversionRate": 1700
}
},
"currentCurrency": "usd"
}
},
"DecryptMessageController": {
"unapprovedDecryptMsgs": "object",
Expand Down Expand Up @@ -231,10 +231,17 @@
"petnamesEnabled": true,
"showMultiRpcModal": "boolean",
"isRedesignedConfirmationsDeveloperEnabled": "boolean",
"redesignedConfirmationsEnabled": true,
"redesignedTransactionsEnabled": "boolean",
"tokenSortConfig": "object",
"shouldShowAggregatedBalancePopover": "boolean"
"tokenNetworkFilter": {
"0x1": "boolean",
"0xaa36a7": "boolean",
"0xe705": "boolean",
"0xe708": "boolean",
"0x539": "boolean"
},
"shouldShowAggregatedBalancePopover": "boolean",
"redesignedConfirmationsEnabled": true,
"redesignedTransactionsEnabled": "boolean"
},
"ipfsGateway": "string",
"isIpfsGatewayEnabled": "boolean",
Expand Down Expand Up @@ -311,6 +318,7 @@
"swapsFeatureFlags": {}
}
},
"TokenBalancesController": { "tokenBalances": "object" },
"TokenListController": {
"tokenList": "object",
"tokensChainsCache": {},
Expand All @@ -327,7 +335,6 @@
},
"TxController": {
"methodData": "object",
"submitHistory": "object",
"transactions": "object",
"lastFetchedBlockNumbers": "object",
"submitHistory": "object"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,22 @@
"petnamesEnabled": true,
"showMultiRpcModal": "boolean",
"isRedesignedConfirmationsDeveloperEnabled": "boolean",
"redesignedConfirmationsEnabled": true,
"redesignedTransactionsEnabled": "boolean",
"tokenSortConfig": "object",
"showMultiRpcModal": "boolean",
"shouldShowAggregatedBalancePopover": "boolean"
"tokenNetworkFilter": {
"0x1": "boolean",
"0xaa36a7": "boolean",
"0xe705": "boolean",
"0xe708": "boolean",
"0x539": "boolean"
},
"shouldShowAggregatedBalancePopover": "boolean",
"redesignedConfirmationsEnabled": true,
"redesignedTransactionsEnabled": "boolean"
},
"firstTimeFlowType": "import",
"completedOnboarding": true,
"knownMethodData": "object",
"use4ByteResolution": true,
"showIncomingTransactions": "object",
"participateInMetaMetrics": true,
"dataCollectionForMarketing": "boolean",
"nextNonce": null,
Expand All @@ -55,12 +60,12 @@
"conversionRate": 1700,
"usdConversionRate": 1700
},
"LineaETH": {
"SepoliaETH": {
"conversionDate": "number",
"conversionRate": 1700,
"usdConversionRate": 1700
},
"SepoliaETH": {
"LineaETH": {
"conversionDate": "number",
"conversionRate": 1700,
"usdConversionRate": 1700
Expand Down Expand Up @@ -135,7 +140,6 @@
"forgottenPassword": false,
"ipfsGateway": "string",
"isIpfsGatewayEnabled": "boolean",
"isMultiAccountBalancesEnabled": "boolean",
"useAddressBarEnsResolution": true,
"ledgerTransportType": "webhid",
"snapRegistryList": "object",
Expand All @@ -145,6 +149,8 @@
"useTransactionSimulations": true,
"enableMV3TimestampSave": true,
"useExternalServices": "boolean",
"isMultiAccountBalancesEnabled": "boolean",
"showIncomingTransactions": "object",
"metaMetricsId": "fake-metrics-id",
"marketingCampaignCookieId": null,
"eventsBeforeMetricsOptIn": "object",
Expand Down Expand Up @@ -182,6 +188,7 @@
"allTokens": {},
"allIgnoredTokens": {},
"allDetectedTokens": {},
"tokenBalances": "object",
"smartTransactionsState": {
"fees": {},
"feesByChainId": "object",
Expand Down Expand Up @@ -229,11 +236,11 @@
"accounts": "object",
"accountsByChainId": "object",
"marketData": "object",
"signatureRequests": "object",
"unapprovedDecryptMsgs": "object",
"unapprovedDecryptMsgCount": 0,
"unapprovedEncryptionPublicKeyMsgs": "object",
"unapprovedEncryptionPublicKeyMsgCount": 0,
"signatureRequests": "object",
"unapprovedPersonalMsgs": "object",
"unapprovedTypedMessages": "object",
"unapprovedPersonalMsgCount": 0,
Expand Down Expand Up @@ -273,16 +280,16 @@
"srcNetworkAllowlist": { "0": "string", "1": "string", "2": "string" },
"destNetworkAllowlist": { "0": "string", "1": "string", "2": "string" }
},
"srcTokens": {},
"srcTopAssets": {},
"destTokens": {},
"destTopAssets": {},
"quoteRequest": {
"slippage": 0.5,
"srcTokenAddress": "0x0000000000000000000000000000000000000000"
"srcTokenAddress": "0x0000000000000000000000000000000000000000",
"slippage": 0.5
},
"quotes": {},
"quotesRefreshCount": 0,
"srcTokens": {},
"srcTopAssets": {}
"quotesRefreshCount": 0
},
"ensEntries": "object",
"ensResolutionsByAddress": "object",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,27 @@
},
"snapsInstallPrivacyWarningShown": true
},
"BridgeController": {
"bridgeState": {
"bridgeFeatureFlags": {
"extensionSupport": "boolean",
"srcNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
},
"destNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
}
},
"destTokens": {},
"destTopAssets": {},
"srcTokens": {},
"srcTopAssets": {}
}
},
"CurrencyController": {
"currentCurrency": "usd",
"currencyRates": {
Expand Down Expand Up @@ -115,10 +136,11 @@
"smartTransactionsOptInStatus": true,
"showNativeTokenAsMainBalance": true,
"petnamesEnabled": true,
"showMultiRpcModal": "boolean",
"isRedesignedConfirmationsDeveloperEnabled": "boolean",
"showConfirmationAdvancedDetails": false,
"tokenSortConfig": "object",
"showMultiRpcModal": "boolean",
"tokenNetworkFilter": {},
"shouldShowAggregatedBalancePopover": "boolean"
},
"selectedAddress": "string",
Expand All @@ -145,27 +167,6 @@
"smartTransactions": "object"
}
},
"BridgeController": {
"bridgeState": {
"bridgeFeatureFlags": {
"extensionSupport": "boolean",
"srcNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
},
"destNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
}
},
"destTokens": {},
"destTopAssets": {},
"srcTokens": {},
"srcTopAssets": {}
}
},
"SubjectMetadataController": { "subjectMetadata": "object" },
"TokensController": {
"allDetectedTokens": {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@
"1": "string",
"2": "string"
}
}
},
"destTokens": {},
"destTopAssets": {},
"srcTokens": {},
"srcTopAssets": {}
}
},
"CurrencyController": {
Expand Down Expand Up @@ -132,10 +136,11 @@
"smartTransactionsOptInStatus": true,
"showNativeTokenAsMainBalance": true,
"petnamesEnabled": true,
"showMultiRpcModal": "boolean",
"isRedesignedConfirmationsDeveloperEnabled": "boolean",
"showConfirmationAdvancedDetails": false,
"tokenSortConfig": "object",
"showMultiRpcModal": "boolean",
"tokenNetworkFilter": {},
"shouldShowAggregatedBalancePopover": "boolean"
},
"selectedAddress": "string",
Expand Down Expand Up @@ -171,27 +176,6 @@
"ignoredTokens": "object",
"tokens": "object"
},
"BridgeController": {
"bridgeState": {
"bridgeFeatureFlags": {
"extensionSupport": "boolean",
"srcNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
},
"destNetworkAllowlist": {
"0": "string",
"1": "string",
"2": "string"
}
},
"destTokens": {},
"destTopAssets": {},
"srcTokens": {},
"srcTopAssets": {}
}
},
"TransactionController": { "transactions": "object" },
"config": "object",
"firstTimeInfo": "object"
Expand Down
Loading
Loading