-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add simulation metrics when simulation UI is not visible #28427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
requested changes
Nov 13, 2024
vinistevam
force-pushed
the
feat-send-simulation-metrics-no-show
branch
from
November 13, 2024 09:04
6f71c0f
to
09928e8
Compare
dabossdana
approved these changes
Nov 13, 2024
Builds ready [603a311]
Page Load Metrics (1718 ± 58 ms)
Bundle size diffs
|
vinistevam
force-pushed
the
feat-send-simulation-metrics-no-show
branch
from
November 13, 2024 14:18
603a311
to
be991f6
Compare
Builds ready [be991f6]
Page Load Metrics (2217 ± 79 ms)
Bundle size diffs
|
vinistevam
approved these changes
Nov 13, 2024
matthewwalsh0
approved these changes
Nov 13, 2024
@@ -19,15 +19,16 @@ const NativeTransferInfo = () => { | |||
<> | |||
<NativeSendHeading /> | |||
<TransactionFlowSection /> | |||
{!isWalletInitiated && ( | |||
{ | |||
<ConfirmInfoSection noPadding> | |||
<SimulationDetails | |||
transaction={transactionMeta} | |||
isTransactionsRedesign | |||
enableMetrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, can we assume this automatically if metricsOnly
is true
?
Builds ready [23f5aac]
Page Load Metrics (1977 ± 78 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds transaction simulation metrics when the UI is not shown and the transaction simulation settings is turned on
Related issues
Fixes: #28369
Manual testing steps
Turn on MetaMetrics settings
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist