Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simulation metrics when simulation UI is not visible #28427

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Nov 12, 2024

Description

This PR adds transaction simulation metrics when the UI is not shown and the transaction simulation settings is turned on

Open in GitHub Codespaces

Related issues

Fixes: #28369

Manual testing steps

Turn on MetaMetrics settings

  1. Go to wallet dashboard
  2. Initiate send transaction directly through wallet
  3. Reject or Cancel the transaction
  4. Observe simulation metrics

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner November 12, 2024 20:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 12, 2024
@vinistevam vinistevam force-pushed the feat-send-simulation-metrics-no-show branch from 6f71c0f to 09928e8 Compare November 13, 2024 09:04
@metamaskbot
Copy link
Collaborator

Builds ready [603a311]
Page Load Metrics (1718 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14682012173013163
domContentLoaded14611987169511455
load14682003171812258
domInteractive1692422010
backgroundConnect872232210
firstReactRender482961205426
getState46014178
initialActions01000
loadScripts10441519122510952
setupStore585182311
uiStartup17472529196217584
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2.06 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@vinistevam vinistevam force-pushed the feat-send-simulation-metrics-no-show branch from 603a311 to be991f6 Compare November 13, 2024 14:18
@metamaskbot
Copy link
Collaborator

Builds ready [be991f6]
Page Load Metrics (2217 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36525522040570274
domContentLoaded19052541217416278
load19202552221716579
domInteractive22100582210
backgroundConnect9144433617
firstReactRender593031527536
getState664322211
initialActions01000
loadScripts13961925159713263
setupStore77616178
uiStartup212832632564296142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 64 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@@ -19,15 +19,16 @@ const NativeTransferInfo = () => {
<>
<NativeSendHeading />
<TransactionFlowSection />
{!isWalletInitiated && (
{
<ConfirmInfoSection noPadding>
<SimulationDetails
transaction={transactionMeta}
isTransactionsRedesign
enableMetrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, can we assume this automatically if metricsOnly is true?

@metamaskbot
Copy link
Collaborator

Builds ready [23f5aac]
Page Load Metrics (1977 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17732467197316780
domContentLoaded17282363194515574
load17852479197716278
domInteractive18242594723
backgroundConnect9114282512
firstReactRender512931367134
getState473272613
initialActions01000
loadScripts12531699143412460
setupStore65612147
uiStartup198328492285226109
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 64 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@cryptotavares cryptotavares added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@vinistevam vinistevam added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 1934a4e Nov 14, 2024
77 checks passed
@vinistevam vinistevam deleted the feat-send-simulation-metrics-no-show branch November 14, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Simulation metrics not captured in the wallet initiated Redesigned Confirmation Send Flow
6 participants