test: [POM] Migrate reveal account srp e2e tests to use Page Object Model

[chloeYue]

Description

• Migrate e2e tests test/e2e/tests/settings/settings-security-reveal-srp.spec.js to TS and Page Object Model, to reduce flakiness.
• Create page classe for privacy and security settings page
• Put all settings related page classes in folder test/e2e/page-objects/pages/settings/
• Deprecate/remove old functions in helper.js

Related issues

Fixes: #28357

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [52d3c80]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1859 ± 114 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	421	2532	1807	389	187
		domContentLoaded	1514	2523	1825	228	110
		load	1558	2576	1859	238	114
		domInteractive	16	97	47	20	9
		backgroundConnect	8	108	34	27	13
		firstReactRender	47	282	101	60	29
		getState	4	77	25	24	11
		initialActions	0	1	0	0	0
		loadScripts	1088	2008	1353	205	99
		setupStore	12	79	35	24	12
		uiStartup	1861	2873	2118	294	141

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

LGTM

[metamaskbot]

Builds ready [5276590]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2020 ± 106 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	433	2621	1943	409	196
		domContentLoaded	1739	2556	1984	206	99
		load	1750	2618	2020	220	106
		domInteractive	29	175	59	33	16
		backgroundConnect	7	96	35	26	12
		firstReactRender	55	275	116	49	23
		getState	5	65	13	16	8
		initialActions	0	1	0	0	0
		loadScripts	1233	1969	1474	186	89
		setupStore	11	61	26	18	9
		uiStartup	1961	2910	2270	251	121

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[seaona]

LGTM! Nice job @chloeYue 🙌

[metamaskbot]

Builds ready [86ddded]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2109 ± 142 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	362	2412	1826	553	266
		domContentLoaded	1723	3124	2079	293	141
		load	1775	3171	2109	295	142
		domInteractive	15	269	67	60	29
		backgroundConnect	8	77	35	23	11
		firstReactRender	53	190	120	33	16
		getState	5	48	11	9	4
		initialActions	0	1	0	0	0
		loadScripts	1236	2523	1540	280	135
		setupStore	7	56	19	18	9
		uiStartup	1985	3442	2346	306	147

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)