feat: UI changes to show decoding data for permits #28342

jpuri · 2024-11-07T09:38:39Z

Description

Changes in permit simulation component to show decoding api results if present. Changes will currently not be visible as signature controller update is not yet done.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3554

Manual testing steps

Locally enable signature decoding using env variables
Submit a permit on test dapp
Check simulation section

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-07T09:38:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri · 2024-11-07T09:42:25Z

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

+    (decodingData === undefined && decodingLoading !== true)
+  ) {
+    return <DefaultSimulation />;
+  }


Here we display decoding api changes if present and fall back to old simulation implementation otherwise.

metamaskbot · 2024-11-07T10:14:16Z

Builds ready [03b89d8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1875 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	182	2123	1723	519	249
		domContentLoaded	1658	2110	1855	128	61
		load	1666	2128	1875	134	64
		domInteractive	20	135	51	29	14
		backgroundConnect	6	70	22	18	9
		firstReactRender	74	284	113	42	20
		getState	5	63	24	23	11
		initialActions	0	1	0	0	0
		loadScripts	1172	1555	1344	105	51
		setupStore	11	63	19	14	7
		uiStartup	1872	2372	2106	147	70

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 4.17 KiB (0.05%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-07T13:57:06Z

Builds ready [75026e4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1865 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1630	2260	1872	160	77
		domContentLoaded	1579	2242	1833	163	78
		load	1590	2268	1865	164	79
		domInteractive	25	75	46	13	6
		backgroundConnect	9	72	32	21	10
		firstReactRender	49	199	100	34	16
		getState	5	84	25	23	11
		initialActions	0	1	0	0	0
		loadScripts	1140	1666	1354	128	61
		setupStore	11	82	29	24	11
		uiStartup	1780	2534	2112	186	89

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 4.17 KiB (0.05%)
common: 0 Bytes (0.00%)

…sion into decoding_api_int

…tension into decoding_ui_changes

metamaskbot · 2024-11-11T07:08:51Z

Builds ready [fbfdfa3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1650 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1505	1818	1662	78	38
		domContentLoaded	1491	1765	1619	65	31
		load	1504	1819	1650	71	34
		domInteractive	22	61	40	13	6
		backgroundConnect	9	71	32	20	9
		firstReactRender	46	202	90	32	16
		getState	5	53	13	13	6
		initialActions	0	1	0	0	0
		loadScripts	1055	1316	1189	62	30
		setupStore	5	87	15	21	10
		uiStartup	1678	2028	1855	98	47

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.06%)
ui: 4.17 KiB (0.05%)
common: 0 Bytes (0.00%)

jpuri · 2024-11-13T23:53:49Z

...mponents/confirm/info/typed-sign/permit-simulation/default-simulation/default-simulation.tsx

@@ -0,0 +1,118 @@
+import { Hex } from '@metamask/utils';


This is old simulation implementation for permits

metamaskbot · 2024-11-14T00:30:31Z

Builds ready [3d75359]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2002 ± 134 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	434	2375	1902	429	206
		domContentLoaded	1495	2361	1979	277	133
		load	1503	2380	2002	278	134
		domInteractive	16	128	52	28	14
		backgroundConnect	9	59	22	16	8
		firstReactRender	45	174	110	32	15
		getState	4	45	12	11	5
		initialActions	0	1	0	0	0
		loadScripts	1086	1793	1479	229	110
		setupStore	5	58	16	17	8
		uiStartup	1684	2638	2212	303	145

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 4.17 KiB (0.05%)
common: 0 Bytes (0.00%)

matthewwalsh0 · 2024-11-15T10:50:39Z

...mponents/confirm/info/typed-sign/permit-simulation/default-simulation/default-simulation.tsx

Minor, would this be more explicit as offline-permit-simulation.tsx?

metamaskbot · 2024-11-15T12:01:16Z

Builds ready [e7b4e61]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1902 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1735	2126	1900	117	56
		domContentLoaded	1725	2081	1880	111	54
		load	1734	2130	1902	122	59
		domInteractive	20	88	43	14	7
		backgroundConnect	9	73	24	17	8
		firstReactRender	61	297	127	52	25
		getState	4	60	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	1277	1571	1389	90	43
		setupStore	5	57	15	17	8
		uiStartup	1948	2667	2158	171	82

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 4.17 KiB (0.05%)
common: 0 Bytes (0.00%)

UI changes to show decoding data for permits

03b89d8

jpuri requested a review from a team as a code owner November 7, 2024 09:38

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 7, 2024

jpuri commented Nov 7, 2024

View reviewed changes

Merge branch 'develop' into decoding_ui_changes

75026e4

jpuri and others added 6 commits November 11, 2024 10:23

Update signature controller and integrate decoding api

602fb20

Update signature controller and integrate decoding api

fc6ab5e

Update LavaMoat policies

228796c

update

2943ebf

Merge branch 'decoding_api_int' of github.com:MetaMask/metamask-exten…

4b04930

…sion into decoding_api_int

UI changes to show decoding data for permits

25e9a00

jpuri changed the base branch from develop to decoding_api_int November 11, 2024 06:25

Merge branch 'decoding_ui_changes' of github.com:MetaMask/metamask-ex…

fbfdfa3

…tension into decoding_ui_changes

Base automatically changed from decoding_api_int to develop November 13, 2024 23:27

HowardBraham requested review from a team as code owners November 13, 2024 23:27

merge

4bcb7f4

jpuri commented Nov 13, 2024

View reviewed changes

update

3d75359

jpuri enabled auto-merge November 14, 2024 04:39

jpuri added 2 commits November 14, 2024 21:28

Merge branch 'develop' into decoding_ui_changes

09eb62a

Merge branch 'develop' into decoding_ui_changes

e7b4e61

matthewwalsh0 approved these changes Nov 15, 2024

View reviewed changes

vinistevam approved these changes Nov 15, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 15, 2024

Merged via the queue into develop with commit 2367e4e Nov 15, 2024
77 checks passed

jpuri deleted the decoding_ui_changes branch November 15, 2024 12:14

github-actions bot locked and limited conversation to collaborators Nov 15, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: UI changes to show decoding data for permits #28342

feat: UI changes to show decoding data for permits #28342

jpuri commented Nov 7, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024

jpuri Nov 7, 2024

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 11, 2024

jpuri Nov 13, 2024

metamaskbot commented Nov 14, 2024

matthewwalsh0 Nov 15, 2024

metamaskbot commented Nov 15, 2024

feat: UI changes to show decoding data for permits #28342

feat: UI changes to show decoding data for permits #28342

Conversation

jpuri commented Nov 7, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 7, 2024

jpuri Nov 7, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 11, 2024

jpuri Nov 13, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 14, 2024

matthewwalsh0 Nov 15, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 15, 2024

jpuri commented Nov 7, 2024 •

edited

Loading