feat: Enable redesigned transaction confirmations for all users

[pedronfigueiredo]

Description

Migrates users to opt in for redesigned transactions. Also adds a method to reenable the old flows for the old e2e tests. Before removing the toggle permanently, we will need to go back and change the e2e tests to support the new flows.

This PR also duplicates tests on the red group below and adds modification to make the tests pass on the redesigned flows.

From the e2e tests that broke with the migration:

• 🔴 Flows that have to be tested before opening up the redesign to everyone (create a duplicate):

  • test/e2e/snaps/test-snap-txinsights-v2.spec.js ✅
  • test/e2e/snaps/test-snap-txinsights.spec.js ✅
  • test/e2e/json-rpc/switchEthereumChain.spec.js ✅
  • test/e2e/tests/request-queuing/batch-txs-per-dapp-diff-network.spec.js ✅
  • test/e2e/tests/request-queuing/batch-txs-per-dapp-extra-tx.spec.js ✅
  • test/e2e/tests/request-queuing/batch-txs-per-dapp-same-network.spec.js ✅
  • test/e2e/tests/request-queuing/dapp1-send-dapp2-signTypedData.spec.js ✅
  • test/e2e/tests/request-queuing/dapp1-switch-dapp2-eth-request-accounts.spec.js ✅
  • test/e2e/tests/request-queuing/dapp1-switch-dapp2-send.spec.js ✅
  • test/e2e/tests/request-queuing/multi-dapp-sendTx-revokePermission.spec.js ✅
  • test/e2e/tests/request-queuing/multiple-networks-dapps-txs.spec.js ✅
  • test/e2e/tests/request-queuing/switch-network.spec.js ✅
  • test/e2e/tests/request-queuing/ui.spec.js ✅

• 🟡 Flows that we don't need to migrate now, but will have to be migrated or adapted when old confirmations flows are deleted

  • test/e2e/json-rpc/eth_sendTransaction.spec.js
  • test/e2e/tests/account/add-account.spec.ts
  • test/e2e/tests/account/snap-account-transfers.spec.ts
  • test/e2e/tests/petnames/petnames-transactions.spec.js
  • test/e2e/tests/ppom/ppom-blockaid-alert-simple-send.spec.js
  • test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js
  • test/e2e/tests/tokens/custom-token-send-transfer.spec.js
  • test/e2e/tests/tokens/nft/erc721-interaction.spec.js
  • test/e2e/tests/tokens/nft/erc1155-interaction.spec.js
  • test/e2e/tests/tokens/nft/send-nft.spec.js
  • test/e2e/tests/transaction/change-assets.spec.js
  • test/e2e/tests/transaction/edit-gas-fee.spec.js
  • test/e2e/tests/transaction/gas-estimates.spec.js
  • test/e2e/tests/transaction/multiple-transactions.spec.js
  • test/e2e/tests/transaction/navigate-transactions.spec.js
  • test/e2e/tests/transaction/send-edit.spec.js
  • test/e2e/tests/transaction/send-eth.spec.js
  • test/e2e/tests/transaction/send-hex-address.spec.js

• 🟢 Flows that we don't need to migrate now, nor do we need to migrate in the future (can be deleted)

  • test/e2e/tests/dapp-interactions/contract-interactions.spec.js
  • test/e2e/tests/dapp-interactions/dapp-tx-edit.spec.js
  • test/e2e/tests/dapp-interactions/failing-contract.spec.js
  • test/e2e/tests/network/network-error.spec.js
  • test/e2e/tests/settings/4byte-directory.spec.js
  • test/e2e/tests/settings/show-hex-data.spec.js
  • test/e2e/tests/tokens/custom-token-add-approve.spec.js
  • test/e2e/tests/tokens/increase-token-allowance.spec.js
  • test/e2e/tests/transaction/simple-send.spec.ts

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3026

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [806f6d6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1936 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	376	2217	1848	384	184
		domContentLoaded	1587	2199	1913	187	90
		load	1637	2219	1936	185	89
		domInteractive	30	195	74	43	20
		backgroundConnect	8	75	22	20	10
		firstReactRender	46	200	115	37	18
		getState	4	47	12	12	6
		initialActions	0	1	0	0	0
		loadScripts	1153	1690	1411	158	76
		setupStore	5	55	13	15	7
		uiStartup	1858	2493	2147	199	96

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 876 Bytes (0.01%)
• ui: 69 Bytes (0.00%)
• common: 0 Bytes (0.00%)