fix (cherry-pick): UX: NetworkList: Ensure setNetworkClientIdForDomain is called for test networks (#25184)

[darkwing]

Description

Cuts down the duplication of the NetworkListItem and ensures that setNetworkClientIdForDomain is called for test networks so that manually choosing a test network sends a signal to the dapp to change chain.

PR: #25195
Commit Hash:
c67aa3f

There were no merge conflicts when picking these commits.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25070?quickstart=1)

Related issues

Fixes: The current Profile Syncing Feature doesn't fully respect Basic
Functionality when turned off. This ensures that the notifications
feature and profile syncing are actually turned off when Basic
Functionality if off.

Manual testing steps

1. Go to a given dapp, connect using Ethereum Mainnet
2. Manually open MetaMask, click the network picker, choose Sepolia
3. See dapp change to sepolia

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask
  Extension Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [7fdad36]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (44 ± 2 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	85	76	7	3
		domContentLoaded	8	14	9	1	1
		load	40	57	44	4	2
		domInteractive	8	14	9	1	1

Bundle size diffs [🚀 Bundle size reduced!]

• background: 22 Bytes (0.00%)
• ui: 6.5 KiB (0.10%)
• common: -3.04 KiB (-0.05%)

[codecov]

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.60%. Comparing base (ba5c428) to head (7fdad36).
Report is 24 commits behind head on Version-v12.0.0.

Files	Patch %	Lines
.../multichain/network-list-menu/network-list-menu.js	70.00%	6 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.0.0   #25260      +/-   ##
===================================================
+ Coverage            65.58%   65.60%   +0.01%     
===================================================
  Files                 1360     1360              
  Lines                54152    54143       -9     
  Branches             14080    14075       -5     
===================================================
+ Hits                 35514    35516       +2     
+ Misses               18638    18627      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.