Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick #25199 to v12 #25255

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 12, 2024

Description

Cherry picks #25199 (4fe3c3e) to v112

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

Fix `yarn audit` error:

```
└─ @grpc/grpc-js
   ├─ ID: 1097506
   ├─ Issue: @grpc/grpc-js can allocate memory for incoming messages well above configured limits
   ├─ URL: GHSA-7v5v-9h63-cj86
   ├─ Severity: moderate
   ├─ Vulnerable Versions: >=1.9.0 <1.9.15
   │ 
   ├─ Tree Versions
   │  └─ 1.9.14
   │ 
   └─ Dependents
      └─ @firebase/firestore@npm:4.6.0 [35f05]

```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25199?quickstart=1)

## **Related issues**


## **Manual testing steps**


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the base branch from develop to Version-v12.0.0 June 12, 2024 13:14
@danjm danjm marked this pull request as ready for review June 12, 2024 13:15
@danjm danjm requested a review from a team as a code owner June 12, 2024 13:15
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (00f7774) to head (c46b97b).
Report is 3 commits behind head on Version-v12.0.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.0.0   #25255   +/-   ##
================================================
  Coverage            65.61%   65.61%           
================================================
  Files                 1359     1359           
  Lines                54169    54169           
  Branches             14098    14098           
================================================
  Hits                 35538    35538           
  Misses               18631    18631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c46b97b]
Page Load Metrics (51 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6711883126
domContentLoaded9211142
load41725194
domInteractive9211142
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.08 KiB (0.09%)
  • common: 3.31 KiB (0.05%)

@danjm danjm added the dependencies Pull requests that update a dependency file label Jun 12, 2024
@danjm danjm merged commit ba5c428 into Version-v12.0.0 Jun 12, 2024
83 checks passed
@danjm danjm deleted the cherry-pick-4fe3c3e-25199 branch June 12, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 12, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants