Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Remove Snaps execution environment override #20173

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 25, 2023

Explanation

This removes the createSnapExecutionService option, as this was never used. If this becomes necessary in the future, a better approach would be to use build flags, to only include the execution environment we need.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@Mrtenz Mrtenz requested a review from a team as a code owner July 25, 2023 09:17
@metamaskbot
Copy link
Collaborator

Builds ready [80e4fb2]
Page Load Metrics (1782 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1032491553818
domContentLoaded14922112178115273
load14922112178215273
domInteractive14922112178115273
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #20173 (80e4fb2) into develop (fdc3558) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20173   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files          985      985           
  Lines        37294    37294           
  Branches     10012    10011    -1     
========================================
  Hits         25889    25889           
  Misses       11405    11405           
Files Changed Coverage Δ
app/scripts/metamask-controller.js 65.43% <ø> (ø)

@Mrtenz Mrtenz merged commit 6914baa into develop Jul 25, 2023
9 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-execution-environment-override branch July 25, 2023 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants