-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] Connect MMI flow in one step less #20143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
albertolive
changed the title
Bugfix/mmi 3509 custody one step
[MMI] Connect MMI in one step less
Jul 24, 2023
albertolive
changed the title
[MMI] Connect MMI in one step less
[MMI] Connect MMI flow in one step less
Jul 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #20143 +/- ##
===========================================
+ Coverage 69.36% 69.36% +0.01%
===========================================
Files 987 987
Lines 37287 37284 -3
Branches 10011 10010 -1
===========================================
+ Hits 25861 25862 +1
+ Misses 11426 11422 -4
|
Builds ready [972d84d]
Page Load Metrics (1578 ± 47 ms)
Bundle size diffs
|
zone-live
approved these changes
Jul 24, 2023
NidhiKJha
approved these changes
Jul 24, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 24, 2023
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Shorten the custodian flow and save valuable time by eliminating one unnecessary step.
Expected
Screen.Recording.2023-07-21.at.10.16.32.mov
Current
Screen.Recording.2023-07-21.at.10.17.48.mov
AC
Pre-merge author checklist
Pre-merge reviewer checklist