Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replace deprecated design system typography consts with enums #19041

Conversation

dhruvv173
Copy link
Contributor

Explanation

This PR is a part of #18714
Replaced deprecated design system typography consts with enums in confirm-data.js and confirm-hexdata.js

File path:

  • ui/components/app/confirm-hexdata/confirm-data.js
  • ui/components/app/confirm-hexdata/confirm-hexdata.js

Screenshots/Screencaps

Before

confirm-data.js

image

confirm-hexdata.js

image

After

confirm-data.js

image

confirm-hexdata.js

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 7, 2023 14:41
@dhruvv173 dhruvv173 requested a review from legobeat May 7, 2023 14:41
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173
Copy link
Contributor Author

Hey @georgewrmarshall
I found a few files which used the deprecated <Typography> (refer the image below)

image
Is it supposed to be changed from <Typography> and <TypographyVariant> to <Text> and <TextVariant>?

If yes, I'd like to work on it, thanks!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 8, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Thanks for your contribution

@dhruvv173
Copy link
Contributor Author

LGTM! 💯 Thanks for your contribution

Could you please check the above comment once?
Thanks!

@georgewrmarshall
Copy link
Contributor

Hey @georgewrmarshall I found a few files which used the deprecated <Typography> (refer the image below)

image Is it supposed to be changed from <Typography> and <TypographyVariant> to <Text> and <TextVariant>?

If yes, I'd like to work on it, thanks!

Hey @dhruvv173, that is correct! You can submit a PR against #17670

@dhruvv173
Copy link
Contributor Author

Hey @georgewrmarshall I found a few files which used the deprecated <Typography> (refer the image below)
image Is it supposed to be changed from <Typography> and <TypographyVariant> to <Text> and <TextVariant>?
If yes, I'd like to work on it, thanks!

Hey @dhruvv173, that is correct! You can submit a PR against #17670

Okay, will do!

@brad-decker brad-decker merged commit 50f2d06 into MetaMask:develop May 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
@dhruvv173 dhruvv173 deleted the Part-of-#18714-Replace-confirm-hexdata branch July 25, 2023 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants