Shallow git clone #18491

HowardBraham · 2023-04-06T19:03:36Z

Does a git clone --depth 1 to speed up every step of the CI by 11 seconds

github-actions · 2023-04-06T19:03:48Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-04-06T19:28:52Z

Builds ready [abc48d3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1547 ± 32 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	157	113	18	9
		domContentLoaded	1423	1665	1543	66	32
		load	1423	1665	1547	67	32
		domInteractive	1423	1665	1543	66	32

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-04-10T12:02:01Z

Builds ready [0c7cad6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1564 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	146	112	14	7
		domContentLoaded	1439	1865	1559	105	50
		load	1439	1865	1564	105	51
		domInteractive	1439	1865	1559	105	50

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

.circleci/config.yml

metamaskbot · 2023-04-13T21:29:38Z

Builds ready [c73a549]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1617 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	411	138	75	36
		domContentLoaded	1371	2036	1600	175	84
		load	1371	2157	1617	201	97
		domInteractive	1371	2036	1600	175	84

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-04-13T23:36:26Z

Builds ready [2d31b85]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1583 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	183	117	27	13
		domContentLoaded	1421	1846	1574	107	52
		load	1443	1846	1583	101	48
		domInteractive	1420	1846	1574	107	52

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

Gudahtt

LGTM!

.circleci/config.yml

Co-authored-by: Mark Stacey <[email protected]>

metamaskbot · 2023-04-21T22:30:47Z

Builds ready [a08405e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1580 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	392	135	61	29
		domContentLoaded	1397	1903	1569	116	56
		load	1397	1903	1580	127	61
		domInteractive	1397	1903	1569	116	56

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

.circleci/config.yml

change from RSA to ED25519 validation Co-authored-by: legobeat <[email protected]>

Co-authored-by: Mark Stacey <[email protected]>

metamaskbot · 2023-04-22T20:12:00Z

Builds ready [88107fd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1567 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	144	114	13	6
		domContentLoaded	1333	1807	1553	128	62
		load	1333	1807	1567	136	65
		domInteractive	1333	1807	1553	128	62

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

legobeat · 2023-04-24T14:27:50Z

@HowardBraham @brad-decker Seems to be breaking for forks https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/43656/workflows/43fa6e4f-eefd-4699-9492-b394826c9c0d/jobs/1227689

Gudahtt · 2023-04-24T14:36:35Z

Curious, I tested this on a fork and it worked fine: https://app.circleci.com/pipelines/github/Gudahtt/metamask-extension/298/workflows/124ebaef-3ea2-499b-bc4b-f76906aefcfa/jobs/4364

Checkout the environment variables, quite different. Mine was from a draft PR, and it looks like it set the repository URL to the fork rather than the target so it worked.

brad-decker · 2023-04-24T15:06:17Z

@legobeat @HowardBraham and @Gudahtt #18783

HowardBraham requested a review from Gudahtt April 6, 2023 19:04

HowardBraham force-pushed the shallow-git-clone branch from cfafd77 to abc48d3 Compare April 6, 2023 19:04

HowardBraham added the team-accounts label Apr 7, 2023

HowardBraham force-pushed the shallow-git-clone branch from 0c7cad6 to fc3795b Compare April 11, 2023 19:12

HowardBraham marked this pull request as ready for review April 11, 2023 19:12

HowardBraham requested review from a team, kumavis and brad-decker as code owners April 11, 2023 19:12

Gudahtt reviewed Apr 11, 2023

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

HowardBraham force-pushed the shallow-git-clone branch 4 times, most recently from 6363e02 to c73a549 Compare April 13, 2023 21:04

HowardBraham force-pushed the shallow-git-clone branch from c73a549 to 2d31b85 Compare April 13, 2023 22:09

Gudahtt previously approved these changes Apr 21, 2023

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

HowardBraham dismissed Gudahtt’s stale review via 9d79aa8 April 21, 2023 21:49

HowardBraham force-pushed the shallow-git-clone branch 2 times, most recently from 6e18bbf to 1092c73 Compare April 21, 2023 21:55

HowardBraham and others added 7 commits April 21, 2023 15:00

Experimenting with a shallow git clone for CircleCI

0c6a8a0

job-publish-prerelease needs the git history

ade06f7

Trying "${CIRCLE_REPOSITORY_URL}"

4cba4d3

Co-authored-by: Mark Stacey <[email protected]>

Trying "$CIRCLE_REPOSITORY_URL"

782863e

echo "$CIRCLE_REPOSITORY_URL"

d02371d

ssh-keyscan

6661103

trying an orb

9d7834b

HowardBraham added 2 commits April 21, 2023 15:00

using an alias

efd679e

Split out $GITHUB_SSH_KEY as a constant with a comment

a08405e

HowardBraham force-pushed the shallow-git-clone branch from 1092c73 to a08405e Compare April 21, 2023 22:01

Gudahtt previously approved these changes Apr 21, 2023

View reviewed changes

legobeat reviewed Apr 22, 2023

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

HowardBraham dismissed Gudahtt’s stale review via 4267a92 April 22, 2023 02:36

HowardBraham and others added 3 commits April 21, 2023 19:36

Update .circleci/config.yml

4267a92

change from RSA to ED25519 validation Co-authored-by: legobeat <[email protected]>

Fix warning about the set -o pipefail option being Bash-specific

596ca0c

Co-authored-by: Mark Stacey <[email protected]>

fixup ssh known-hosts key

88107fd

legobeat approved these changes Apr 22, 2023

View reviewed changes

Gudahtt approved these changes Apr 24, 2023

View reviewed changes

brad-decker merged commit b704a3d into develop Apr 24, 2023

brad-decker deleted the shallow-git-clone branch April 24, 2023 14:19

github-actions bot locked and limited conversation to collaborators Apr 24, 2023

HowardBraham added the contributor experience An issue that impacts, or planned improvement to, the contributor experience. label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shallow git clone #18491

Shallow git clone #18491

HowardBraham commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

metamaskbot commented Apr 6, 2023

metamaskbot commented Apr 10, 2023

metamaskbot commented Apr 13, 2023

metamaskbot commented Apr 13, 2023

Gudahtt left a comment

metamaskbot commented Apr 21, 2023

metamaskbot commented Apr 22, 2023

legobeat commented Apr 24, 2023

Gudahtt commented Apr 24, 2023

brad-decker commented Apr 24, 2023

Shallow git clone #18491

Shallow git clone #18491

Conversation

HowardBraham commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

metamaskbot commented Apr 6, 2023

metamaskbot commented Apr 10, 2023

metamaskbot commented Apr 13, 2023

metamaskbot commented Apr 13, 2023

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 21, 2023

metamaskbot commented Apr 22, 2023

legobeat commented Apr 24, 2023

Gudahtt commented Apr 24, 2023

brad-decker commented Apr 24, 2023