Merge branch 'brian/upgrade-assets-controllers-43' into brian/upgrade…

…-assets-controllers-44
MetaMask · Nov 15, 2024 · 33d683f · 33d683f
2 parents 8978d6d + 979a3af
commit 33d683f
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/ui/pages/asset/useHistoricalPrices.ts b/ui/pages/asset/useHistoricalPrices.ts
@@ -31,8 +31,8 @@ export const useHistoricalPrices = ({
   const [loading, setLoading] = useState<boolean>(chainSupported);
   const [data, setData] = useState<HistoricalPrices>({});
 
-  if (chainSupported) {
-    useEffect(() => {
+  useEffect(() => {
+    if (chainSupported) {
       setLoading(true);
       fetchWithCache({
         url: `https://price.api.cx.metamask.io/v1/chains/${chainId}/historical-prices/${address}?vsCurrency=${currency}&timePeriod=${timeRange}`,
@@ -59,7 +59,11 @@ export const useHistoricalPrices = ({
           setData({ prices, edges });
           setLoading(false);
         });
-    }, [chainId, address, currency, timeRange]);
-  }
+    } else {
+      setData({});
+      setLoading(false);
+    }
+  }, [chainSupported, chainId, address, currency, timeRange]);
+
   return { loading, data };
 };