Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: use vite build tools to replace the outdated gulp and browserify to support ledger clear signing requirement #239

Draft
wants to merge 8 commits into
base: gh-pages
Choose a base branch
from
Draft

Feat: use vite build tools to replace the outdated gulp and browserify to support ledger clear signing requirement #239

wants to merge 8 commits into from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Aug 13, 2024 •
edited
Loading

description:

This PR is prerequirement change to support ledger clear sign feature.
This PR link to following issue and project plan
#217
clear sign feature plan

The PR has done following change:

  1. remove all old gulp and browserify lib dependancy in package.json
  2. add yarn 4.3.1 Pnp as pacakge management tools for the project.
  3. Add vite to our project list ( i have compared and test parcel js which ledger team recommend, and i have created branch to use parceljs for this feature, and it work with subpath export feature, however i find out parcel is not good enough for customisation and split the big files into chunk during build, therefore, i choose better build tools call vitejs for this feature)
  4. update the ledgerHQ library to latest to support clear signing feature.
  5. Customise the vite.config.js file to support legacy browsers and modern browsers. (will bundle both legacy minified files and modern minified files to support both modern browsers and legacy browsers)

⚠️ Merge to gh-pages may deploy the code to live in the public, which will affect the metamask extension user. so we need to double check this change didn't break the current ledger feature in metamask extension before merge the PR.

@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

@socket-security Socket Security
Copy link

Report is too large to display inline.
View full report↗︎

Next steps

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-accounts team-hardware-wallets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dawnseeker8