feat: use remote-feature-flag-controller for bridge flags #5708
+802
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BridgeController and related utilities to consume feature flags via the RemoteFeatureFlagController rather than the Bridge API. Key changes include:
- Refactoring the feature flag validation and type definitions to use a unified PlatformConfig.
- Modifying the fetch function to retrieve feature flags using a messenger call instead of direct API fetch.
- Updating selectors, tests, and changelogs to align with the new feature flag structure.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bridge-controller/src/utils/validators.ts | Updated validator to check against PlatformConfigSchema instead of legacy keys. |
| packages/bridge-controller/src/utils/fetch.ts | Rewrote feature flag fetching to use the RemoteFeatureFlagController and updated config extraction. |
| packages/bridge-controller/src/utils/fetch.test.ts | Modified tests to work with the new fetch signature and default config behavior. |
| packages/bridge-controller/src/types.ts | Removed client-specific feature flag keys and updated type definitions. |
| packages/bridge-controller/src/selectors.ts | Removed featureFlagsKey parameter and simplified state access. |
| packages/bridge-controller/src/constants/bridge.ts | Updated default state configuration to use the new flattened structure. |
| packages/bridge-controller/src/bridge-controller.ts | Adjusted feature flag usage and interval configuration logic. |
| packages/bridge-controller/src/bridge-controller.test.ts | Updated tests to validate the new feature flag values and messenger mocks. |
| packages/bridge-controller/CHANGELOG.md | Added a breaking change note regarding the new feature flag source. |
Files not reviewed (3)
- packages/bridge-controller/package.json: Language not supported
- packages/bridge-controller/tsconfig.build.json: Language not supported
- packages/bridge-controller/tsconfig.json: Language not supported
Comments suppressed due to low confidence (2)
packages/bridge-controller/src/utils/fetch.ts:46
- Remove or replace this debugging log before production deployment to avoid leaking internal state information.
console.log('HELLO remoteFeatureFlagControllerState', remoteFeatureFlagControllerState);
packages/bridge-controller/src/utils/fetch.test.ts:226
- [nitpick] Consider updating the test description to more accurately reflect that the function returns a fallback default config on error rather than throwing an exception.
it('should handle fetch error', async () => {
infiniteflower
force-pushed
the
feat/bridge-remote-feature-flag-controller
branch
from
69af7a1 to
f1847b2
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…eFeatureFlagController
infiniteflower
force-pushed
the
feat/bridge-remote-feature-flag-controller
branch
from
b225df4 to
47d1bd5
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
micaelae
reviewed
Apr 29, 2025
| @@ -350,14 +336,13 @@ export enum BridgeUserAction { | |||
| UPDATE_QUOTE_PARAMS = 'updateBridgeQuoteRequestParams', | |||
| } | |||
| export enum BridgeBackgroundAction { | |||
| SET_FEATURE_FLAGS = 'setBridgeFeatureFlags', | |||
| SET_CHAIN_INTERVAL_LENGTH = 'setChainIntervalLength', | |||
There was a problem hiding this comment.
Do the clients need to call this handler? Or can we set the interval length within the controller as needed?
There was a problem hiding this comment.
#setIntervalLength used to be called inside setBridgeFeatureFlags but since that's gone now, I just put it into its own function setChainIntervalLength and made it public to maintain the previous behavior where it could be called by clients, on say Bridge UI init.
I do notice that we previously called #setIntervalLength (now setChainIntervalLength) inside updateBridgeQuoteRequestParams. Do we need to call this from the client if it's called when we update the quote request?
micaelae
reviewed
Apr 30, 2025
| @@ -60,7 +60,8 @@ export type BridgeAppState = BridgeControllerState & { | |||
| gasFeeEstimates: GasFeeEstimates; | |||
| } & ExchangeRateControllerState & { | |||
| participateInMetaMetrics: boolean; | |||
| }; | |||
| } & { bridgeConfig: Json }; | |||
|
|
|||
There was a problem hiding this comment.
Can we use this as the expected type from clients instead? So we can just pass in the entire state of the RemoteFeatureFlagsController
Suggested change
| } & { | |
| remoteFeatureFlags: { | |
| bridgeConfig: Json; | |
| }; | |
| }; |
micaelae
reviewed
Apr 30, 2025
| }; | ||
|
|
||
| const createFeatureFlagsSelector = createSelector_.withTypes<{ | ||
| bridgeConfig: unknown; | ||
| }>(); |
There was a problem hiding this comment.
Similar comment as above regarding remoteFeatureFlags controller stat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the
BridgeControllerto consume feature flags from theRemoteFeatureFlagControllerrather than the Bridge API.References
Checklist