Skip to content

Feat: remove current chain id dependency asset contract controllers #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: feat/make-chainId-mandatory-in-nft-controller
Choose a base branch
from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 23, 2025

Explanation

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@salimtb salimtb changed the base branch from main to feat/make-chainId-mandatory-in-nft-controller April 23, 2025 09:09
@salimtb salimtb changed the base branch from feat/make-chainId-mandatory-in-nft-controller to main April 23, 2025 09:09
@sahar-fehri
Copy link
Contributor

I have already made updates separately for the NFT controller updates; i think its worth getting that one in first to make less work on this PR

@salimtb salimtb changed the title Feat/remove current chain id dependency asset contract controllers Feat: remove current chain id dependency asset contract controllers Apr 28, 2025
@salimtb salimtb changed the base branch from main to feat/make-chainId-mandatory-in-nft-controller April 28, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants