Skip to content

Support Multi-srp backups in SeedlessOnboardingController #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: feat/seedless-onboarding-controller
Choose a base branch
from
Draft

Support Multi-srp backups in SeedlessOnboardingController #5685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11d6552
feat: added 'encryptionKey' and 'encryptionSalt' to state
lwin-kyaw Apr 22, 2025
5a2953c
feat: add new private method, 'verifyPassword` to verify password val…
lwin-kyaw Apr 22, 2025
3aa52ba
feat: updated vault encryption scheme
lwin-kyaw Apr 22, 2025
5347ab5
feat: add new method 'addNewSeedPhraseBackup' for multi-srp
lwin-kyaw Apr 22, 2025
3301236
fix: fixed vaultEncKey and password check
lwin-kyaw Apr 22, 2025
534f04c
test: updated tests for multi-srp and new vault encryption scheme
lwin-kyaw Apr 22, 2025
b795ed6
feat: updated vault and added lock
lwin-kyaw Apr 29, 2025
cf0e9dd
Merge remote-tracking branch 'origin/feat/seedless-onboarding-control…
lwin-kyaw Apr 29, 2025
18db087
fix: updated array order from fetchAllSeedlPhrases method
lwin-kyaw Apr 29, 2025
b10a458
fix: fixed tests
lwin-kyaw Apr 29, 2025
8578a48
fix: updated 'MissingCredentials' error message
lwin-kyaw Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/seedless-onboarding-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-controller": "^21.0.3",
"@noble/ciphers": "^0.5.2",
"@noble/curves": "^1.2.0",
"@noble/hashes": "^1.4.0",
Expand All @@ -70,6 +71,9 @@
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
},
"peerDependencies": {
"@metamask/keyring-controller": "^21.0.0"
},
"engines": {
"node": "^18.18 || >=20"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/seedless-onboarding-controller/src/SeedPhraseMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class SeedPhraseMetadata implements ISeedPhraseMetadata {
/**
* Parse the seed phrase metadata from the metadata store and return the array of raw seed phrases.
*
* This method also sorts the seed phrases by timestamp in descending order, i.e. the newest seed phrase will be the first element in the array.
* This method also sorts the seed phrases by timestamp in ascending order, i.e. the oldest seed phrase will be the first element in the array.
*
* @param seedPhraseMetadataArr - The array of SeedPhrase Metadata from the metadata store.
* @returns The array of raw seed phrases.
Expand Down Expand Up @@ -141,7 +141,7 @@ export class SeedPhraseMetadata implements ISeedPhraseMetadata {
*/
static sort(
seedPhrases: SeedPhraseMetadata[],
order: 'asc' | 'desc' = 'desc',
order: 'asc' | 'desc' = 'asc',
): SeedPhraseMetadata[] {
return seedPhrases.sort((a, b) => {
if (order === 'asc') {
Expand Down
Loading
Loading