feat: integrate phishing protection into NftController #5598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This is not a complete PR. But my initial jab at this so lets talk about this more tomorrow
NFT Metadata URL Safety: Moving Phishing Detection from UI to Controller
Overview
This PR implements security enhancements by moving NFT metadata URL safety checks from the UI layer to the controller level. It ensures potentially malicious URLs in NFT metadata are detected and filtered before reaching the UI components.
Changes
NftController
that checks all external links in NFT metadataPhishingController
's URL scanning capabilityTechnical Details
#sanitizeNftMetadata
that checks all URLs in metadataPhishingController
integration_getNftInformation
to sanitize metadata after retrievalReferences
Changelog
Checklist