Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable smart transactions by default for new users #4885

Merged
merged 2 commits into from
Nov 6, 2024
Merged

feat: enable smart transactions by default for new users #4885

merged 2 commits into from
Nov 6, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 1, 2024 •
edited by MajorLift
Loading

Explanation

We want to enable smart transactions by default for new users.

References

Changelog

@metamask/preferences-controller

### Changed

- Enable smart transactions by default for new users by setting the initial value of the `smartTransactionsOptInStatus` state property to 'true' ([#4885](https://github.com/MetaMask/core/pull/4885))

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@dan437 dan437 requested a review from a team as a code owner November 1, 2024 13:16
@dan437 dan437 added the team-transactions Transactions team label Nov 1, 2024
@dan437 dan437 changed the title chore: enable smart transactions by default for new users feat: enable smart transactions by default for new users Nov 1, 2024
@dan437 dan437 mentioned this pull request Nov 1, 2024
Open
7 tasks
@dan437 dan437 enabled auto-merge (squash) November 5, 2024 10:57
mikesposito
mikesposito approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dan437 dan437 merged commit b27a5d7 into main Nov 6, 2024
120 checks passed
@dan437 dan437 deleted the enable-stx-for-new-users branch November 6, 2024 14:03
@dan437 dan437 mentioned this pull request Nov 8, 2024
Merged
dan437 added a commit that referenced this pull request Nov 8, 2024
@dan437
Release/244.0.0 (#4909)
13567c0 
## Explanation
New release with preferences-controller changes:
#4885

## References


## Changelog


## Checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

@mikesposito mikesposito mikesposito approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees
No one assigned
Labels
team-transactions Transactions team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan437 @pedronfigueiredo @mikesposito @infiniteflower