Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add validation to ensure gas fields are valid hexadecimal #4854

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Oct 28, 2024

Explanation

This PR aims to add validation to ensure gas fields are valid hexadecimal.

References

fixes MetaMask/metamask-mobile#11774

Changelog

@metamask/transaction-controller

  • Added: Validation for gas values to ensure they are valid hexadecimal

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@vinistevam
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-374ec2c3",
  "@metamask-previews/address-book-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/announcement-controller": "7.0.1-preview-374ec2c3",
  "@metamask-previews/approval-controller": "7.1.0-preview-374ec2c3",
  "@metamask-previews/assets-controllers": "39.0.0-preview-374ec2c3",
  "@metamask-previews/base-controller": "7.0.1-preview-374ec2c3",
  "@metamask-previews/build-utils": "3.0.1-preview-374ec2c3",
  "@metamask-previews/chain-controller": "0.1.3-preview-374ec2c3",
  "@metamask-previews/composable-controller": "9.0.1-preview-374ec2c3",
  "@metamask-previews/controller-utils": "11.4.0-preview-374ec2c3",
  "@metamask-previews/ens-controller": "14.0.1-preview-374ec2c3",
  "@metamask-previews/eth-json-rpc-provider": "4.1.5-preview-374ec2c3",
  "@metamask-previews/gas-fee-controller": "21.0.0-preview-374ec2c3",
  "@metamask-previews/json-rpc-engine": "10.0.0-preview-374ec2c3",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.4-preview-374ec2c3",
  "@metamask-previews/keyring-controller": "17.3.0-preview-374ec2c3",
  "@metamask-previews/logging-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/message-manager": "11.0.0-preview-374ec2c3",
  "@metamask-previews/multichain": "0.0.0-preview-374ec2c3",
  "@metamask-previews/name-controller": "8.0.1-preview-374ec2c3",
  "@metamask-previews/network-controller": "22.0.0-preview-374ec2c3",
  "@metamask-previews/notification-controller": "7.0.0-preview-374ec2c3",
  "@metamask-previews/notification-services-controller": "0.12.0-preview-374ec2c3",
  "@metamask-previews/permission-controller": "11.0.2-preview-374ec2c3",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-374ec2c3",
  "@metamask-previews/phishing-controller": "12.2.0-preview-374ec2c3",
  "@metamask-previews/polling-controller": "11.0.0-preview-374ec2c3",
  "@metamask-previews/preferences-controller": "13.1.0-preview-374ec2c3",
  "@metamask-previews/profile-sync-controller": "0.9.7-preview-374ec2c3",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-374ec2c3",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/selected-network-controller": "18.0.2-preview-374ec2c3",
  "@metamask-previews/signature-controller": "20.1.0-preview-374ec2c3",
  "@metamask-previews/transaction-controller": "37.3.0-preview-374ec2c3",
  "@metamask-previews/user-operation-controller": "16.0.0-preview-374ec2c3"
}

@vinistevam
Copy link
Contributor Author

@vinistevam vinistevam merged commit 506071e into main Nov 4, 2024
120 checks passed
@vinistevam vinistevam deleted the fix/add-is-valid-hex-gas-fields branch November 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants