Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NOTIFY-1140): add batch PUT endpoint for account syncing #4724

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 23, 2024

Explanation

This PR replaces the singular PUTs by batch PUTs for account syncing.

References

NOTIFY-1140

Changelog

@metamask/profile-sync-controller

  • CHANGED: use batch endpoint instead of singular requests to update user storage for account syncing

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 23, 2024
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@mathieuartu mathieuartu marked this pull request as ready for review September 23, 2024 09:20
@mathieuartu mathieuartu requested a review from a team as a code owner September 23, 2024 09:20
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-cf2e569",
  "@metamask-previews/address-book-controller": "6.0.1-preview-cf2e569",
  "@metamask-previews/announcement-controller": "7.0.1-preview-cf2e569",
  "@metamask-previews/approval-controller": "7.0.4-preview-cf2e569",
  "@metamask-previews/assets-controllers": "38.0.1-preview-cf2e569",
  "@metamask-previews/base-controller": "7.0.1-preview-cf2e569",
  "@metamask-previews/build-utils": "3.0.1-preview-cf2e569",
  "@metamask-previews/chain-controller": "0.1.2-preview-cf2e569",
  "@metamask-previews/composable-controller": "9.0.1-preview-cf2e569",
  "@metamask-previews/controller-utils": "11.3.0-preview-cf2e569",
  "@metamask-previews/ens-controller": "14.0.1-preview-cf2e569",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-cf2e569",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-cf2e569",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-cf2e569",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-cf2e569",
  "@metamask-previews/keyring-controller": "17.2.1-preview-cf2e569",
  "@metamask-previews/logging-controller": "6.0.1-preview-cf2e569",
  "@metamask-previews/message-manager": "10.1.1-preview-cf2e569",
  "@metamask-previews/name-controller": "8.0.1-preview-cf2e569",
  "@metamask-previews/network-controller": "21.0.1-preview-cf2e569",
  "@metamask-previews/notification-controller": "6.0.1-preview-cf2e569",
  "@metamask-previews/notification-services-controller": "0.8.0-preview-cf2e569",
  "@metamask-previews/permission-controller": "11.0.2-preview-cf2e569",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-cf2e569",
  "@metamask-previews/phishing-controller": "12.0.3-preview-cf2e569",
  "@metamask-previews/polling-controller": "10.0.1-preview-cf2e569",
  "@metamask-previews/preferences-controller": "13.0.3-preview-cf2e569",
  "@metamask-previews/profile-sync-controller": "0.8.1-preview-cf2e569",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-cf2e569",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-cf2e569",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-cf2e569",
  "@metamask-previews/signature-controller": "19.1.0-preview-cf2e569",
  "@metamask-previews/transaction-controller": "37.0.0-preview-cf2e569",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-cf2e569"
}

@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-9735ac7",
  "@metamask-previews/address-book-controller": "6.0.1-preview-9735ac7",
  "@metamask-previews/announcement-controller": "7.0.1-preview-9735ac7",
  "@metamask-previews/approval-controller": "7.0.4-preview-9735ac7",
  "@metamask-previews/assets-controllers": "38.0.1-preview-9735ac7",
  "@metamask-previews/base-controller": "7.0.1-preview-9735ac7",
  "@metamask-previews/build-utils": "3.0.1-preview-9735ac7",
  "@metamask-previews/chain-controller": "0.1.2-preview-9735ac7",
  "@metamask-previews/composable-controller": "9.0.1-preview-9735ac7",
  "@metamask-previews/controller-utils": "11.3.0-preview-9735ac7",
  "@metamask-previews/ens-controller": "14.0.1-preview-9735ac7",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-9735ac7",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-9735ac7",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-9735ac7",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-9735ac7",
  "@metamask-previews/keyring-controller": "17.2.1-preview-9735ac7",
  "@metamask-previews/logging-controller": "6.0.1-preview-9735ac7",
  "@metamask-previews/message-manager": "10.1.1-preview-9735ac7",
  "@metamask-previews/name-controller": "8.0.1-preview-9735ac7",
  "@metamask-previews/network-controller": "21.0.1-preview-9735ac7",
  "@metamask-previews/notification-controller": "6.0.1-preview-9735ac7",
  "@metamask-previews/notification-services-controller": "0.8.0-preview-9735ac7",
  "@metamask-previews/permission-controller": "11.0.2-preview-9735ac7",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-9735ac7",
  "@metamask-previews/phishing-controller": "12.0.3-preview-9735ac7",
  "@metamask-previews/polling-controller": "10.0.1-preview-9735ac7",
  "@metamask-previews/preferences-controller": "13.0.3-preview-9735ac7",
  "@metamask-previews/profile-sync-controller": "0.8.1-preview-9735ac7",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-9735ac7",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-9735ac7",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-9735ac7",
  "@metamask-previews/signature-controller": "19.1.0-preview-9735ac7",
  "@metamask-previews/transaction-controller": "37.0.0-preview-9735ac7",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-9735ac7"
}

@mathieuartu mathieuartu merged commit c525459 into main Sep 23, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/account_sync_batch_updates branch September 23, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants