Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove providerConfig from NetworkController #4254

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Remove providerConfig from NetworkController #4254

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65fa9a8
Remove providerConfig from NetworkController
mcmire Jun 7, 2024
17ce10b
Merge branch 'main' into remove-provider-config
mcmire Jun 10, 2024
d66f6f3
Merge branch 'main' into remove-provider-config
mcmire Jun 11, 2024
da1d37f
Remove extra reference to providerConfig that slipped in
mcmire Jun 11, 2024
bdf6b90
Fix TokenRatesController
mcmire Jun 11, 2024
33b273e
Reach coverage thresholds by removing unnecessary checks and adding i…
mcmire Jun 11, 2024
034ff51
Merge branch 'main' into remove-provider-config
mcmire Jun 11, 2024
478f001
Merge branch 'main' into remove-provider-config
mcmire Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/network-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- **BREAKING:** Update `networksMetadata` state property so that the keys in the object will only ever be network client IDs and not RPC URLs ([#4254](https://github.com/MetaMask/core/pull/4254))
- Some keys could have been RPC URLs if the initial network controller state had a `providerConfig` with an empty `id`, but since `providerConfig` is being removed, that won't happen anymore.

### Removed

- **BREAKING:** Remove `providerConfig` property from state along with `ProviderConfig` type and `NetworkController:getProviderConfig` messenger action ([#4254](https://github.com/MetaMask/core/pull/4254))
- The best way to obtain the equivalent configuration object, e.g. to access the chain ID of the currently selected network, is to get `selectedNetworkClientId` from state, pass this to the `NetworkController:getNetworkClientId` messenger action, and then use the `configuration` property on the network client.

## [19.0.0]

### Changed
Expand Down
Loading
Loading